Skip to content
This repository has been archived by the owner on Apr 5, 2022. It is now read-only.

Add ESLint to satellite along with anti trojan plugin #21

Merged

Conversation

dhillonks
Copy link
Contributor

Description

Added ESLint as a part of Seneca-CDOT/telescope#2560 and Seneca-CDOT/telescope#2533

Changes:

  • Added and configured ESLint
  • Fixed linting errors
  • Configued ESLint with jest
  • Added anti trojan source plugin
  • Modified the pre-commit hook through husky to also run eslint

@dhillonks dhillonks changed the title Add ESLint to satellite along with anti trojan Add ESLint to satellite along with anti trojan plugin Dec 3, 2021
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
test.js Outdated Show resolved Hide resolved
@dhillonks dhillonks force-pushed the issue-2533-add-anti-trojan-plugin branch from 7f09d01 to 2ef7dcf Compare December 3, 2021 16:33
@dhillonks dhillonks requested a review from humphd December 3, 2021 16:34
src/middleware.js Outdated Show resolved Hide resolved
jest.config.js Show resolved Hide resolved
.eslintrc.js Outdated Show resolved Hide resolved
src/middleware.js Outdated Show resolved Hide resolved
.eslintrc.js Outdated Show resolved Hide resolved
* adding and configuring eslint

* Fixing linting errors

* configuring anti-trojan-source plugin

* adding lint to pre-commit hook

* Removing ts from eslint run and removing comment

* removing unused function validateAuthorizationOptions

* Adding no-unused-vars override to test.js and removing the override from config
@dhillonks dhillonks force-pushed the issue-2533-add-anti-trojan-plugin branch from 2ef7dcf to 54aaf1d Compare December 5, 2021 22:35
@dhillonks dhillonks requested a review from humphd December 5, 2021 22:40
@humphd
Copy link
Contributor

humphd commented Dec 6, 2021

@dhillonks can you do another PR that builds on this to add the lint check to our CI/CD workflows? https://github.com/Seneca-CDOT/satellite/blob/master/.github/workflows

@humphd humphd merged commit d5c35e0 into DevelopingSpace:master Dec 6, 2021
@dhillonks
Copy link
Contributor Author

@dhillonks can you do another PR that builds on this to add the lint check to our CI/CD workflows? https://github.com/Seneca-CDOT/satellite/blob/master/.github/workflows

on it!

@dhillonks dhillonks mentioned this pull request Dec 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants