New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dns record instruction page #545
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Ririio love this idea, did you implement it in your environment on my branch? If so feel free to push |
Oh I don't think it's a good idea for me to mess around with your branch, it's simple to implement actually, just follow the example here |
|
I like @Ririio's UI with tabs, that's a good idea. It mimics what we're doing in certificates too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice improvements. A few small things.
|
Looks like this needs a rebase too to get the changes to the main DNS Records page. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
R+ from me with the eslint fix.
d667e04
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if it's necessary, but for FAQ, I think user might ask what the difference is between a "dns-record" and "domain"
|
@Myrfion please rebase and squash this properly, don't merge |
Sorry I merged in main, before your message 😕 |





I think that this one has a good potential for expansion, such as adding more faq sections and more instructions
closes #443