Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSONP / Cross-site scripting is missing #63

Closed
pbakaus opened this issue Jun 28, 2015 · 3 comments
Closed

JSONP / Cross-site scripting is missing #63

pbakaus opened this issue Jun 28, 2015 · 3 comments

Comments

@pbakaus
Copy link

pbakaus commented Jun 28, 2015

Heya,

Just started building JavaScript based app using the Implicit OAuth flow and authenticating works fine, but now I'm stuck, as neither JSONP or CORS seems to be available to make requests.

Option A: Support "format=jsonp", i.e. when passing in a callback, it should return with "callback(orig response)".

Option B: Support CORS: http://enable-cors.org/index.html

Otherwise there seems to be no way to do requests from JS right now, which is a pity!

Thanks much,
Paul

@muteor
Copy link
Collaborator

muteor commented Jun 28, 2015

CORS is sent when the client is set to implicit in the client settings.

@muteor muteor closed this as completed Jun 28, 2015
@pbakaus
Copy link
Author

pbakaus commented Jun 28, 2015

mhh, thanks for the advice but I can confirm it's not working. My client is set to Implicit, yet CORS isn't working. Anything else I need to configure? Does it have something to do with the original_url thing?

@muteor
Copy link
Collaborator

muteor commented Jun 29, 2015

We have multiple clients already using this and they are working, I checked your client and it is set correctly.

If you are still having issues please send a request/response log showing the headers sent back from the server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants