Please increase the maximum of the custom sounds #950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheRealMoeder
approved these changes
Dec 31, 2019
|
Thanks! I added some sound fx and noticed that after the internal id 217 (after the reenumeration) to my controller was hanging. Limit can be lower, 450 or so, just to have space for around 60-100 extra custom sounds https://github.com/eried/Research/tree/master/JumperT8SG/soundfx |
|
Development around deviation is rather quiet, we might as well merge this. If we ever run into ram issues, we can rethink things. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.