perf(jetsocat,dgw): reuse buffer in JMUX sender task #975
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Performance is increased by ~26.3%. Before this patch: > 0.0000-19.0245 sec 25.2 GBytes 11.4 Gbits/sec After this patch: > 0.0000-17.1307 sec 28.8 GBytes 14.4 Gbits/sec
awakecoding
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We’re spending a lot of time dealing with
BytesandBytesMutin the JMUX sender task.This patch is getting rid of the leftmost drop. We can actually reuse the
BytesMutbuffer between writes and greatly reduces allocation / de-allocation.Performance is increased by ~26.3%.
Before this patch:
After this patch: