fix: keep context selection visible in compact terminals#214
Conversation
- improve context table selected-row contrast - avoid empty filter spacing in the context picker - cover compact context picker rendering
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughExtracts a dedicated high-contrast selected-row style, conditionally skips rendering an empty context filter to save vertical space, and adds tests verifying compact-terminal rendering and the selected style's colors. ChangesContext Picker Visibility in Compact Terminals
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Comment |
![amazon-q-developer[bot]](https://avatars.githubusercontent.com/in/1220912?s=60&v=4){kind=small}
There was a problem hiding this comment.
This PR successfully addresses the compact terminal visibility issue with clean, well-tested code. The refactoring improves both code organization and user experience by removing empty filter spacing and enhancing visual contrast. The changes are minimal, focused, and properly validated with appropriate test coverage.
You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@internal/app/context_table.go`:
- Around line 52-56: The use of the deprecated lipgloss.Style.Copy() call in
contextTableSelectedStyle should be removed; instead create a new style by
assigning selectedStyle to a local variable (e.g., base := selectedStyle) and
then chain Bold/Foreground/Background on that variable, replacing
selectedStyle.Copy() in contextTableSelectedStyle; make the identical change in
the test expectation (the styles_test.go expectation around the previous Copy
usage) so both production and test no longer call Copy().
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 107a38b4-253e-49d6-afcf-5926e56aa17b
📒 Files selected for processing (3)
internal/app/context_table.gointernal/app/screen_context.gointernal/app/styles_test.go
- replace new lipgloss Copy usage in context selected style - update the matching style expectation
2 participants
Summary
Improves the context picker in short IDE terminal panes by removing the empty filter spacer when no filter is active, which lets the picker fit without middle truncation. Also raises the selected-row contrast so the active context remains visually obvious across dark terminal themes.
Adds compact-height rendering coverage to keep the selected context and help bar visible without the truncation marker.
Related Issues
Closes #212
Validation
Checklist
Summary by CodeRabbit
Bug Fixes
Style
Tests