feat: add context filter modifier actions#217
Conversation
- Handle ctrl+y and ctrl+s while context filtering is active - Keep plain y/s as filter input and document the shortcuts - Cover filter-mode copy/setup behavior in context picker tests
There was a problem hiding this comment.
Summary
This PR successfully adds filter-mode modifier shortcuts (Ctrl+S and Ctrl+Y) to the context picker, enabling users to setup or copy exports for filtered contexts without leaving filter mode. The implementation is clean, follows existing patterns, and includes comprehensive test coverage.
Changes:
- Added Ctrl+S and Ctrl+Y keyboard shortcuts that work in filter mode
- Updated README documentation to reflect the new shortcuts
- Added context-aware help text that displays the shortcuts when in filter mode
- Included thorough unit tests covering both the UI display and actual functionality
Quality:
- ✅ Code follows established patterns and conventions
- ✅ Comprehensive test coverage with 4 new test cases
- ✅ Documentation updated appropriately
- ✅ No defects identified that block merge
The feature enhances user experience by reducing the number of steps needed to act on filtered contexts.
You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
📜 Recent review details🧰 Additional context used📓 Path-based instructions (4)**/*.go📄 CodeRabbit inference engine (CLAUDE.md)
Files:
⚙️ CodeRabbit configuration file
Files:
internal/app/**⚙️ CodeRabbit configuration file
Files:
README.md📄 CodeRabbit inference engine (CLAUDE.md)
Files:
⚙️ CodeRabbit configuration file
Files:
**/*_test.go📄 CodeRabbit inference engine (CLAUDE.md)
Files:
⚙️ CodeRabbit configuration file
Files:
🔇 Additional comments (5)
WalkthroughThis PR adds modifier-key actions ( ChangesContext Picker Filter Mode Modifier Actions
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning Review ran into problems🔥 ProblemsGit: Failed to clone repository. Please run the Comment |
Summary
Adds filter-mode modifier shortcuts to the context picker so users can act on the selected filtered context without first leaving filter mode.
Related Issues
Closes #213
Validation
Checklist
Summary by CodeRabbit
Release Notes
New Features
Ctrl+Sshortcut to set up the selected filtered context in the Context Picker.Ctrl+Yshortcut to copy exports for the selected filtered context.Documentation