New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue 28] Linux not rendering #29

Merged
merged 1 commit into from Feb 25, 2015

Conversation

Projects
None yet
3 participants
@growlercab
Contributor

growlercab commented Feb 24, 2015

This is a trivial fix for the Linux rendering issue I encountered with the latest Dgame.

NOTE: I have only tested this on Arch Linux x86_64.

@growlercab

This comment has been minimized.

Contributor

growlercab commented Feb 24, 2015

I just had a thought...when I commented out this line:

SDL_GL_SetAttribute(SDL_GL_CONTEXT_FLAGS,SDL_GL_CONTEXT_FORWARD_COMPATIBLE_FLAG);

it fixed the Linux rendering. It might be that it will also fix the blank screen rendering issue on MAC as well, as reported on Dlang forums here:

http://forum.dlang.org/thread/cwmvdndazklelixtqrru@forum.dlang.org?page=3

This PR fixes the linux render issue by bypassing the entire block that selects the GL version. The real fix for all platforms might be just don't set that forward compatible bit.

I don't have a MAC to test this theory, sorry. If you do get a chance to test it and it works, let me know and I can update this PR accordingly. Or feel free to reject this PR completely if you prefer.

However, I'd rather be running GL 4.5 than GL 3.0 if I can and this PR lets me do that :)

@growlercab

This comment has been minimized.

Contributor

growlercab commented Feb 24, 2015

OK my idea didn't work on MAC as reported in the dlang forums:

http://forum.dlang.org/thread/cwmvdndazklelixtqrru@forum.dlang.org?page=5

This PR will only fix Dgame on linux and should not change the current behaviour on MAC.

@Dgame

This comment has been minimized.

Owner

Dgame commented Feb 25, 2015

Then I have no clue what fails on Mac. :/

@growlercab

This comment has been minimized.

Contributor

growlercab commented Feb 25, 2015

No, me neither. It's hard without a MAC to try things out too so I cannot help much unfortunately.

Do you think you will merge this PR or should I just close it?

It fixes Linux, which is currently broken in 0.4.2, but it's only a patch job until a proper x-platform can be worked out.

@Dgame

This comment has been minimized.

Owner

Dgame commented Feb 25, 2015

Since I have no clue how to fix that on a Mac yet, I will merge it. Thank you again.

Dgame added a commit that referenced this pull request Feb 25, 2015

@Dgame Dgame merged commit 74a0a5c into Dgame:master Feb 25, 2015

@growlercab growlercab deleted the growlercab:I28_linux_no_sprites branch Feb 25, 2015

@growlercab

This comment has been minimized.

Contributor

growlercab commented Feb 25, 2015

thanks for merging, I just tested and Linux is now working again in 0.4.3 :)

@Dgame

This comment has been minimized.

Owner

Dgame commented Feb 25, 2015

Nice to hear! :)

@rikkimax

This comment has been minimized.

rikkimax commented Feb 26, 2015

@Dgame

This comment has been minimized.

Owner

Dgame commented Feb 26, 2015

I've already suggested that. According to him, this does not change anything:
http://forum.dlang.org/thread/cwmvdndazklelixtqrru@forum.dlang.org?page=3#post-djwtqcjnxnnyfvygalol:40forum.dlang.org

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment