New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed SDL logo of tests and smooth filter setter of Texture #39

Merged
merged 2 commits into from Apr 30, 2015

Conversation

Projects
None yet
2 participants
@kr41
Contributor

kr41 commented Apr 30, 2015

Hi! The SDL logo from this example did not work properly with custom masks because of invalid type of pixel array uint.

I have not found any proper solution for using color masks within asHex() of Color4b struct (as we discussed it on my previous pull request). And frankly, it is not an issue for me. If I confront with it on real project, I will think how to implement it.

I also fixed smooth filter setter of Texture in the same way as it is done within setRepeat(). By the way, I think it would be better to replace that setters and getters by properties. What do you think about it?

@Dgame

This comment has been minimized.

Owner

Dgame commented Apr 30, 2015

What was wrong with the filter? Or did you mean that the user could only set it before the texture was placed in the memory?
And no, I think the user should know that he is not just setting a single variable. If the setter would be a property, the user could think that and could accidentally misuse that. That's why I've decided against properties in the first place.

@kr41

This comment has been minimized.

Contributor

kr41 commented Apr 30, 2015

Yes, I mean that filter used to work only before loading.

And no, I think the user should know that he is not just setting a single variable.

I thought about it too. Let it be explicit.

@Dgame

This comment has been minimized.

Owner

Dgame commented Apr 30, 2015

All right, then let us merge it!

Dgame added a commit that referenced this pull request Apr 30, 2015

Merge pull request #39 from kr41/master
Fixed SDL logo of tests and smooth filter setter of Texture

@Dgame Dgame merged commit f9db3d8 into Dgame:master Apr 30, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment