Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamically choose crop ratio #36

Closed
Dor-Sloim opened this issue Oct 12, 2019 · 6 comments
Closed

Dynamically choose crop ratio #36

Dor-Sloim opened this issue Oct 12, 2019 · 6 comments
Assignees

Comments

@Dor-Sloim
Copy link

Is there an option to let your users choose crop ratio dynamically?
If not, could you add one using the https://github.com/Yalantis/uCrop library?

@Dhaval2404
Copy link
Owner

Dhaval2404 commented Oct 12, 2019

@Dor-Sloim Sorry, I didn't get your exact requirement. uCrop is already added in this lib. Currently, you can pass crop ration as below:

ImagePicker.with(this)
	.crop(16f, 9f)	//Crop image with 16:9 aspect ratio
	.start()

Here, the crop method is optional.

@Dor-Sloim
Copy link
Author

I want to be able to do:
ImagePicker.with(this) .**crop()** .start()
Then, when the user crops, he can change the aspect ratio.

@Dhaval2404
Copy link
Owner

@Dor-Sloim I will try to integrate the feature in the next few hours.

Thank you so much for the feedback.

@Dor-Sloim
Copy link
Author

Thank you so much !
This might help you:

If you want to let your users choose crop ratio dynamically, just do not call withAspectRatio(x, y).

Dhaval2404 added a commit that referenced this issue Oct 12, 2019
Allow users to Crop Image without specifying the aspect ratio and let users choose aspect ration at the time of crop.

#36
@Dor-Sloim
Copy link
Author

Great.
When do you think you will release

implementation 'com.github.dhaval2404:imagepicker:1.5'

I'l be more than happy to test it and let you know if i find any bugs.
And again, Thank you so much !

Dhaval2404 added a commit that referenced this issue Oct 13, 2019
Release v1.5 with below fixes

#28 #34 #36
@Dhaval2404 Dhaval2404 mentioned this issue Oct 13, 2019
@Dhaval2404
Copy link
Owner

@Dor-Sloim Can you please check out the latest lib.

@Dhaval2404 Dhaval2404 self-assigned this Oct 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants