Update mask used in setWaveForm / getWaveForm to preserve 3rd bit for opl3 #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was trying to figure out why my waveforms didn't sound right, then found this.
Note that setInstrumet uses the right mask, which is why loading presets / whole instruments works fine.
Far as I can tell it's fine to have this extra 3rd bit around even on an opl2 (though it won't be respected) -- since setInstrument does that already.
I updated setDrumInstrument as well, but I've not read up on the details for drums yet so let me know if I should remove that one.