Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show promotions and description on the pipeline #113

Closed

Conversation

@cooolmagic
Copy link

cooolmagic commented May 29, 2015

Show promotions and description on the pipeline. Both are configurable(on/off) via config page.

…e(on/off) via config page.
@cooolmagic

This comment has been minimized.

Copy link
Author

cooolmagic commented May 29, 2015

Few more details about show descriptions:

  • User can configure view to show job descriptions on the pipeline

About show promotions:

  • User can configure view to show job promotions on the pipeline
  • It will show all promotions in descending order of start time
  • It will show promotion badge, title, duration and user

Here are few screenshots:

image

@coveralls

This comment has been minimized.

Copy link

coveralls commented May 29, 2015

Coverage Status

Coverage decreased (-3.71%) to 95.5% when pulling 0a5733b on cooolmagic:ShowDescriptionAndPromotions into 9713b00 on Diabol:master.

@cooolmagic

This comment has been minimized.

Copy link
Author

cooolmagic commented May 29, 2015

Here is how we are using these features in our enterprise pipeline. This one heavily uses description feature.

untitled

@dawidmalina

This comment has been minimized.

Copy link
Contributor

dawidmalina commented Jun 4, 2015

Looks promising. Is it possible to make test coverage happy?

@tommysdk

This comment has been minimized.

Copy link
Contributor

tommysdk commented Jun 4, 2015

Really nice feature! Good job! I've been missing the ability to have the test stats (tests run, failed, skipped) easily accessible from the pipeline view.

Is there a JIRA ticket for this issue? If not, please create one so we can keep track of all changes going into the plugin.

Could you please take a look if you can raise the test coverage?

@cooolmagic

This comment has been minimized.

Copy link
Author

cooolmagic commented Jun 4, 2015

Ah.. I want to. But some of promotion plugin classes are final and cannot be mocked by Mockito. And I would hate to introduce PowerMock or something similar. Thoughts?

Added more unit test coverage
@coveralls

This comment has been minimized.

Copy link

coveralls commented Jun 5, 2015

Coverage Status

Coverage decreased (-0.85%) to 98.36% when pulling 9b58c6c on cooolmagic:ShowDescriptionAndPromotions into 9713b00 on Diabol:master.

@cooolmagic

This comment has been minimized.

Copy link
Author

cooolmagic commented Jun 5, 2015

Ok. I have improvised a little and added some more coverage. See if this is acceptable?

@tommysdk

This comment has been minimized.

Copy link
Contributor

tommysdk commented Jun 5, 2015

We'll take a look at it as soon as possible, thanks!

@patbos

This comment has been minimized.

Copy link
Member

patbos commented Jun 6, 2015

Thanks for the PR! Looks good. I have one issue. Promoted Build Plugin is an optional dependency. But in the code added in this PR uses classes in the Promoted Build Plugin directly. This will make Promoted Build Plugin dependency mandatory. I would prefer to still have the dependency to Promoted Build Plugin optional.

@dawidmalina

This comment has been minimized.

Copy link
Contributor

dawidmalina commented Jun 10, 2015

Any update for this PR. @patbos maybe you can propose @cooolmagic howto deal with your requirement about dependency.

abnath added 3 commits Jun 10, 2015
Refactor code to make promotion status provide optional extension.
Merged from master and resolved conflicts
Added more code coverage
@cooolmagic

This comment has been minimized.

Copy link
Author

cooolmagic commented Jun 12, 2015

I have made the changes to make promotion status as optional extension. Please take a look.

@patbos

This comment has been minimized.

Copy link
Member

patbos commented Jun 15, 2015

Looks good! I will do some local testing and come back.

@patbos

This comment has been minimized.

Copy link
Member

patbos commented Jun 24, 2015

@cooolmagic Have done some testing now and the optional extension works!
Cant merge the PR now since it has a couple of conflicts. Please merge from master and squash the commits.

Resolving merges from master
@dawidmalina

This comment has been minimized.

Copy link
Contributor

dawidmalina commented Aug 10, 2015

@cooolmagic looks like you forgot to finish junit test part. Changes in TestResult and Task are ready but you prabably missed changes on DeliveryPipelineView and pipe.js.

It should fixed this issue: JENKINS-22843

@cooolmagic

This comment has been minimized.

Copy link
Author

cooolmagic commented Aug 13, 2015

@dawidmalina JENKINS-22843 looks like a new feature request. I took the latest 0.9.5 and everything is working as expected.

@dawidmalina

This comment has been minimized.

Copy link
Contributor

dawidmalina commented Aug 13, 2015

@cooolmagic I don't see option to show TestResult from Task. There were 2 new properties:
private boolean showDescription = false;
private boolean showPromotions = false;

There is no option to show TestResult on view configuration page. See https://github.com/Diabol/delivery-pipeline-plugin/blob/master/src/main/java/se/diabol/jenkins/pipeline/DeliveryPipelineView.java

Same for https://github.com/Diabol/delivery-pipeline-plugin/blob/master/src/main/webapp/pipe.js I don't see section like on your screens (Tests run x, Failures x, Skipped x).

But changes acording TestResult and new property on Task class was proposed in this PR.

So if this part will be compleated it will somehow cover JENKINS-22843.

@tommysdk

This comment has been minimized.

Copy link
Contributor

tommysdk commented Aug 14, 2015

What is the JIRA ticket associated with this particular PR?

@cooolmagic

This comment has been minimized.

Copy link
Author

cooolmagic commented Aug 25, 2015

@dawidmalina Ahh.. those test results in screenshot are set via description. We have a post build groovy script that parses console logs and set test results in description which are the reflected on the pipeline. I believe hudson has no direct API for test results. But there are indirect ways via optional 'aggregate junit reports' plugin. I will explore more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.