Show promotions and description on the pipeline

[abnath]

Show promotions and description on the pipeline. Both are configurable(on/off) via config page.

[dawidmalina]

This is prabably continuation of this #113. @patbos when you can merge this?

[patbos]

Got this errors every second build when I build master after merge:
Tests run: 7, Failures: 0, Errors: 4, Skipped: 0, Time elapsed: 6.789 sec <<< FAILURE! - in se.diabol.jenkins.pipeline.domain.TaskTest
testGetAg(se.diabol.jenkins.pipeline.domain.TaskTest) Time elapsed: 0.943 sec <<< ERROR!
java.lang.NullPointerException: null
at se.diabol.jenkins.pipeline.domain.status.SimpleStatus.isBuildPromoted(SimpleStatus.java:193)
at se.diabol.jenkins.pipeline.domain.status.SimpleStatus.getStatusFromResult(SimpleStatus.java:176)
at se.diabol.jenkins.pipeline.domain.status.SimpleStatus.resolveStatus(SimpleStatus.java:167)
at se.diabol.jenkins.pipeline.domain.Task.getAggregatedTask(Task.java:199)
at se.diabol.jenkins.pipeline.domain.TaskTest.testGetAg(TaskTest.java:78)

testFailedThenQueued(se.diabol.jenkins.pipeline.domain.TaskTest) Time elapsed: 0.526 sec <<< ERROR!
java.lang.NullPointerException: null
at se.diabol.jenkins.pipeline.domain.status.SimpleStatus.isBuildPromoted(SimpleStatus.java:193)
at se.diabol.jenkins.pipeline.domain.status.SimpleStatus.getStatusFromResult(SimpleStatus.java:179)
at se.diabol.jenkins.pipeline.domain.status.SimpleStatus.resolveStatus(SimpleStatus.java:167)
at se.diabol.jenkins.pipeline.domain.Task.getLatestTask(Task.java:176)
at se.diabol.jenkins.pipeline.domain.TaskTest.testFailedThenQueued(TaskTest.java:164)

testIsRebuildableNoPermission(se.diabol.jenkins.pipeline.domain.TaskTest) Time elapsed: 1.79 sec <<< ERROR!
java.lang.NullPointerException: null
at se.diabol.jenkins.pipeline.domain.status.SimpleStatus.isBuildPromoted(SimpleStatus.java:193)
at se.diabol.jenkins.pipeline.domain.status.SimpleStatus.getStatusFromResult(SimpleStatus.java:179)
at se.diabol.jenkins.pipeline.domain.status.SimpleStatus.resolveStatus(SimpleStatus.java:167)
at se.diabol.jenkins.pipeline.domain.Task.getLatestTask(Task.java:176)
at se.diabol.jenkins.pipeline.domain.TaskTest.testIsRebuildableNoPermission(TaskTest.java:215)

testIsRebuildable(se.diabol.jenkins.pipeline.domain.TaskTest) Time elapsed: 1.1 sec <<< ERROR!
java.lang.NullPointerException: null
at se.diabol.jenkins.pipeline.domain.status.SimpleStatus.isBuildPromoted(SimpleStatus.java:193)
at se.diabol.jenkins.pipeline.domain.status.SimpleStatus.getStatusFromResult(SimpleStatus.java:179)
at se.diabol.jenkins.pipeline.domain.status.SimpleStatus.resolveStatus(SimpleStatus.java:167)
at se.diabol.jenkins.pipeline.domain.Task.getLatestTask(Task.java:176)
at se.diabol.jenkins.pipeline.domain.TaskTest.testIsRebuildable(TaskTest.java:184)

[cooolmagic]

@patbos Not sure how these tests where passing before. Looks like they are not mocking their dependencies and are accessing shared states (in static fields). For now I have added null checks and tests are now passing for me. See PR 125.

[cooolmagic]

@patbos @dawidmalina Do you know when is the next plugin release will be?