Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show promotions and description on the pipeline #124

Merged
merged 2 commits into from Jul 1, 2015
Merged

Conversation

@abnath
Copy link
Contributor

abnath commented Jun 25, 2015

Show promotions and description on the pipeline. Both are configurable(on/off) via config page.

abnath added 2 commits Jun 25, 2015
Show promotions and description on the pipeline. Both are
configurable(on/off) via config page.
@dawidmalina

This comment has been minimized.

Copy link
Contributor

dawidmalina commented Jun 29, 2015

This is prabably continuation of this #113. @patbos when you can merge this?

patbos added a commit that referenced this pull request Jul 1, 2015
Show promotions and description on the pipeline
@patbos patbos merged commit adf2830 into Diabol:master Jul 1, 2015
1 of 2 checks passed
1 of 2 checks passed
coverage/coveralls Coverage decreased (-0.48%) to 98.77%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@patbos

This comment has been minimized.

Copy link
Member

patbos commented Jul 1, 2015

Got this errors every second build when I build master after merge:
Tests run: 7, Failures: 0, Errors: 4, Skipped: 0, Time elapsed: 6.789 sec <<< FAILURE! - in se.diabol.jenkins.pipeline.domain.TaskTest
testGetAg(se.diabol.jenkins.pipeline.domain.TaskTest) Time elapsed: 0.943 sec <<< ERROR!
java.lang.NullPointerException: null
at se.diabol.jenkins.pipeline.domain.status.SimpleStatus.isBuildPromoted(SimpleStatus.java:193)
at se.diabol.jenkins.pipeline.domain.status.SimpleStatus.getStatusFromResult(SimpleStatus.java:176)
at se.diabol.jenkins.pipeline.domain.status.SimpleStatus.resolveStatus(SimpleStatus.java:167)
at se.diabol.jenkins.pipeline.domain.Task.getAggregatedTask(Task.java:199)
at se.diabol.jenkins.pipeline.domain.TaskTest.testGetAg(TaskTest.java:78)

testFailedThenQueued(se.diabol.jenkins.pipeline.domain.TaskTest) Time elapsed: 0.526 sec <<< ERROR!
java.lang.NullPointerException: null
at se.diabol.jenkins.pipeline.domain.status.SimpleStatus.isBuildPromoted(SimpleStatus.java:193)
at se.diabol.jenkins.pipeline.domain.status.SimpleStatus.getStatusFromResult(SimpleStatus.java:179)
at se.diabol.jenkins.pipeline.domain.status.SimpleStatus.resolveStatus(SimpleStatus.java:167)
at se.diabol.jenkins.pipeline.domain.Task.getLatestTask(Task.java:176)
at se.diabol.jenkins.pipeline.domain.TaskTest.testFailedThenQueued(TaskTest.java:164)

testIsRebuildableNoPermission(se.diabol.jenkins.pipeline.domain.TaskTest) Time elapsed: 1.79 sec <<< ERROR!
java.lang.NullPointerException: null
at se.diabol.jenkins.pipeline.domain.status.SimpleStatus.isBuildPromoted(SimpleStatus.java:193)
at se.diabol.jenkins.pipeline.domain.status.SimpleStatus.getStatusFromResult(SimpleStatus.java:179)
at se.diabol.jenkins.pipeline.domain.status.SimpleStatus.resolveStatus(SimpleStatus.java:167)
at se.diabol.jenkins.pipeline.domain.Task.getLatestTask(Task.java:176)
at se.diabol.jenkins.pipeline.domain.TaskTest.testIsRebuildableNoPermission(TaskTest.java:215)

testIsRebuildable(se.diabol.jenkins.pipeline.domain.TaskTest) Time elapsed: 1.1 sec <<< ERROR!
java.lang.NullPointerException: null
at se.diabol.jenkins.pipeline.domain.status.SimpleStatus.isBuildPromoted(SimpleStatus.java:193)
at se.diabol.jenkins.pipeline.domain.status.SimpleStatus.getStatusFromResult(SimpleStatus.java:179)
at se.diabol.jenkins.pipeline.domain.status.SimpleStatus.resolveStatus(SimpleStatus.java:167)
at se.diabol.jenkins.pipeline.domain.Task.getLatestTask(Task.java:176)
at se.diabol.jenkins.pipeline.domain.TaskTest.testIsRebuildable(TaskTest.java:184)

@cooolmagic

This comment has been minimized.

Copy link

cooolmagic commented Jul 2, 2015

@patbos Not sure how these tests where passing before. Looks like they are not mocking their dependencies and are accessing shared states (in static fields). For now I have added null checks and tests are now passing for me. See PR 125.

@cooolmagic

This comment has been minimized.

Copy link

cooolmagic commented Jul 8, 2015

@patbos @dawidmalina Do you know when is the next plugin release will be?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.