Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JENKINS-34041 Added Themes for DPP and ability to select from different options #178

Merged
merged 1 commit into from May 11, 2016

Conversation

@pskumar448
Copy link
Contributor

pskumar448 commented May 7, 2016

Along with this fixed some of the issues in pagination which got effected with themes feature.

@pskumar448

This comment has been minimized.

Copy link
Contributor Author

pskumar448 commented May 7, 2016

Travis build failed because of OutOfMemory exception.
Pls re-trigger the Travis-CI

@coveralls

This comment has been minimized.

Copy link

coveralls commented May 7, 2016

Coverage Status

Coverage increased (+0.07%) to 97.351% when pulling 6608242 on pskumar448:master into eef31f3 on Diabol:master.

@pskumar448

This comment has been minimized.

Copy link
Contributor Author

pskumar448 commented May 9, 2016

@tommysdk
Have a look at this and let me know your feedback.

…nt options

Along with this fixed some of the issues in pagination which got
effected with themes feature
@coveralls

This comment has been minimized.

Copy link

coveralls commented May 9, 2016

Coverage Status

Coverage increased (+0.2%) to 97.481% when pulling e3fd206 on pskumar448:master into eef31f3 on Diabol:master.

@tommysdk

This comment has been minimized.

Copy link
Contributor

tommysdk commented May 10, 2016

@pskumar448 Thank you for your continued effort on the plugin! I will go through the PR as soon as possible and get back to you with feedback.

@pskumar448

This comment has been minimized.

Copy link
Contributor Author

pskumar448 commented May 11, 2016

@tommysdk
This works like this,
Created themes folder and under this folder we are going to have different themes with unique folder names, each theme folder contains the set of files style sheets & images.
After having a new theme folder, we are going to update the configure-entries.jelly with the theme name in select box.

@@ -351,7 +351,7 @@ function generatePromotionsInfo(data, task) {
if (data.showPromotions && task.status.promoted && task.status.promotions && task.status.promotions.length > 0) {
var html = ["<div class='infoPanelOuter'>"];
Q.each(task.status.promotions, function(i, promo) {
html.push("<div class='infoPanel'><div class='infoPanelInner'>");
html.push("<div class='infoPanel'><div class='infoPanelInner'><div class='promo-layer'>");

This comment has been minimized.

Copy link
@tommysdk

tommysdk May 11, 2016

Contributor

What does the div class='promo-layer' add?

This comment has been minimized.

Copy link
@pskumar448

pskumar448 May 11, 2016

Author Contributor

Actually there is no wrapper div for showing promotions. It uses general
info panel layers. To specify any styles specifically to promotions info
for this I have included promo-layer.
On 11 May 2016 11:59 pm, "Tommy Tynjä" notifications@github.com wrote:

In src/main/webapp/pipe.js
#178 (comment)
:

@@ -351,7 +351,7 @@ function generatePromotionsInfo(data, task) {
if (data.showPromotions && task.status.promoted && task.status.promotions && task.status.promotions.length > 0) {
var html = ["

"];
Q.each(task.status.promotions, function(i, promo) {

  •        html.push("<div class='infoPanel'><div class='infoPanelInner'>");
    
  •        html.push("<div class='infoPanel'><div class='infoPanelInner'><div class='promo-layer'>");
    

What does the div class='promo-layer' add?


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/Diabol/delivery-pipeline-plugin/pull/178/files/e3fd206e4c5948deb3913ba33ebf60b47f5a1ad6#r62901068

This comment has been minimized.

Copy link
@tommysdk

tommysdk May 11, 2016

Contributor

I see, make sense. Good!

@tommysdk

This comment has been minimized.

Copy link
Contributor

tommysdk commented May 11, 2016

Just browsed through the change set. Neat solution. I'm going to try it out locally now.

@tommysdk

This comment has been minimized.

Copy link
Contributor

tommysdk commented May 11, 2016

I think the proposed solution looks good! I will add a second theme and then merge it.
I'm a bit curious on the bootstrap theme mentioned in the JIRA issue, see my comments there as well.

@tommysdk tommysdk merged commit 93292c8 into Diabol:master May 11, 2016
4 of 5 checks passed
4 of 5 checks passed
codecov/patch 75.00% of diff hit (target 94.44%)
Details
codecov/changes No unexpected coverage changes found.
Details
codecov/project 94.57% (+0.08%) compared to eef31f3
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.2%) to 97.481%
Details
@tommysdk

This comment has been minimized.

Copy link
Contributor

tommysdk commented May 11, 2016

Thanks for yet another contribution! Much appreciated. I also added another theme (PR 180) which is also merged to master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.