New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JENKINS-22283 Show upstream jobs #224

Merged
merged 12 commits into from Apr 10, 2017

Conversation

Projects
None yet
4 participants
@tommysdk
Contributor

tommysdk commented Dec 6, 2016

Rebased PR 213 with current master and made some refactoring (extract method/classes) as well as added some unit test assertions.

List<AbstractProject> firstProjects = ProjectUtil.getStartUpstreams(getFirstProject());
List<AbstractBuild> builds = resolveBuilds(firstProjects);
//TODO check if in queue

This comment has been minimized.

@tommysdk

tommysdk Dec 10, 2016

Contributor

@patbos what were your thoughts here?

@tommysdk

tommysdk Dec 10, 2016

Contributor

@patbos what were your thoughts here?

@tommysdk

This comment has been minimized.

Show comment
Hide comment
@tommysdk

tommysdk Dec 10, 2016

Contributor

Previous test coverage concerns have been addressed. I think this feature is quite ready to be merged. @patbos Could you please test and review?

Contributor

tommysdk commented Dec 10, 2016

Previous test coverage concerns have been addressed. I think this feature is quite ready to be merged. @patbos Could you please test and review?

@bsideup

This comment has been minimized.

Show comment
Hide comment
@bsideup

bsideup Jan 12, 2017

Contributor

Hey @tommysdk @patbos,
Any progress here?

Contributor

bsideup commented Jan 12, 2017

Hey @tommysdk @patbos,
Any progress here?

@tommysdk

This comment has been minimized.

Show comment
Hide comment
@tommysdk

tommysdk Jan 12, 2017

Contributor

@bsideup I've been waiting for @patbos feedback on this one but I consider this good to go so if there are no objections I plan to merge this soon.

Contributor

tommysdk commented Jan 12, 2017

@bsideup I've been waiting for @patbos feedback on this one but I consider this good to go so if there are no objections I plan to merge this soon.

@tommysdk

This comment has been minimized.

Show comment
Hide comment
@tommysdk

tommysdk Apr 5, 2017

Contributor

Good to merge.

Contributor

tommysdk commented Apr 5, 2017

Good to merge.

@patbos

patbos approved these changes Apr 5, 2017

@tommysdk tommysdk merged commit 8b9bdc1 into Diabol:master Apr 10, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@tommysdk tommysdk deleted the tommysdk:JENKINS-22283 branch Apr 10, 2017

@patbos patbos removed the in progress label Apr 10, 2017

@KostyaSha

This comment has been minimized.

Show comment
Hide comment
@KostyaSha

KostyaSha Apr 11, 2017

You have two 1.0.0 tags in gh, what is the difference?
PS don't forget to publish tag in gh ;)

KostyaSha commented Apr 11, 2017

You have two 1.0.0 tags in gh, what is the difference?
PS don't forget to publish tag in gh ;)

@tommysdk

This comment has been minimized.

Show comment
Hide comment
@tommysdk

tommysdk Apr 11, 2017

Contributor

@KostyaSha release-1.0.0 is a tag created to trigger the automatic release of a new version of the Delivery Pipeline plugin. The other tag corresponds to the actual release made by the automated process.

Contributor

tommysdk commented Apr 11, 2017

@KostyaSha release-1.0.0 is a tag created to trigger the automatic release of a new version of the Delivery Pipeline plugin. The other tag corresponds to the actual release made by the automated process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment