Improve module structure #275
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@shihab-dls the diff is huge, but there are hardly any actual code changes. Could you just have a scan through and see if you think where I have moved things around make sense, and that the imports are nicer? |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #275 +/- ##
==========================================
+ Coverage 89.38% 90.37% +0.98%
==========================================
Files 46 68 +22
Lines 2280 2368 +88
==========================================
+ Hits 2038 2140 +102
+ Misses 242 228 -14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
shihab-dls
previously approved these changes
Nov 24, 2025
Contributor
shihab-dls
left a comment
shihab-dls
left a comment
There was a problem hiding this comment.
Super nice! No notes, approving
GDYendell
force-pushed
the
module-structure
branch
from
3785701 to
75782d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #253
Summary
Organise modules into directories with a small number of modules at the root, such as
control_system,launchandtracerSplit most files with multiple classes into separate files
Update imports, patches and docs ignores
Rename some typevars
T->DType_Tso that drivers can useTfor general generic type hints without clashesRename Numerical -> Numeric
Import public APIs in
__init__.pys to simplify import pathsBreaking Changes
from fastcs.datatypes import T->from fastcs.datatypes import DType_Tfrom fastcs.attribute_io->from fastcs.attributesfrom fastcs.attribute_io_ref->from fastcs.attributesfrom fastcs.controller->from fastcs.controllersfrom fastcs.cs_methods->from fastcs.methodsfrom fastcs.transport->from fastcs.transportsfrom fastcs.wrappers->from fastcs.methodsfrom fastcs.attributes import ONCE->from fastcs.util import ONCEfastcs.transport.epics.options import EpicsGUIOptions, EpicsIOCOptions->from fastcs.transports.epics import EpicsGUIOptions, EpicsIOCOptionsfrom fastcs.transport.epics.ca.transport import EpicsCATransport->from fastcs.transports.epics.ca import EpicsCATransport