forked from frappe/erpnext
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: set Purchase Receipt status based on qty instead of amount #597
Merged
Alchez
merged 5 commits into
Bloomstack:staging
from
Alchez:feat-purchase-receipt-bill-status
Sep 28, 2020
Merged
feat: set Purchase Receipt status based on qty instead of amount #597
Alchez
merged 5 commits into
Bloomstack:staging
from
Alchez:feat-purchase-receipt-bill-status
Sep 28, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 2280
💛 - Coveralls |
Alchez
force-pushed
the
feat-purchase-receipt-bill-status
branch
from
September 24, 2020 12:18
a469e2d
to
55e80de
Compare
hrwX
suggested changes
Sep 25, 2020
Comment on lines
+558
to
+575
pr_details = frappe.db.sql(""" | ||
SELECT | ||
pr_item.name, | ||
pr_item.qty, | ||
pr_item.parent | ||
FROM | ||
`tabPurchase Receipt Item` pr_item, | ||
`tabPurchase Receipt` pr | ||
WHERE | ||
pr.name = pr_item.parent | ||
AND pr_item.purchase_order_item = %s | ||
AND pr.docstatus = 1 | ||
AND pr.is_return = 0 | ||
ORDER BY | ||
pr.posting_date asc, | ||
pr.posting_time asc, | ||
pr.name asc | ||
""", po_detail, as_dict=1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Use ORM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure how I can do joins using the ORM. I tried using the list-filters way, but it didn't give me any results.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
billed_qty
for each Purchase Receipt ItemConsiderations: