Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move cron and cronsummary tasks to be under the oppiamobile directory? #530

Closed
alexlittle opened this issue Dec 18, 2018 · 2 comments
Closed
Labels
enhancement medium priority refectoring/review Any areas of code that could be improved/refactored

Comments

@alexlittle
Copy link
Member

Seems to make more sense to have them running from there with all the other server settings

@alexlittle alexlittle added enhancement medium priority refectoring/review Any areas of code that could be improved/refactored labels Dec 18, 2018
@jjoseba
Copy link
Member

jjoseba commented Dec 18, 2018

I think the best approach for this would be to call this tasks using a management command, instead of calling directly the python file and having to load the Django path from the bash script. Right now, the cronsummary task is already exposed as update_summaries management command, so it can be called directly using manage.py update_summaries.
Then, the task would be to create a similar management command for the other task, and rewrite the bash scripts so they call them using the manage.py mechanism.

@alexlittle
Copy link
Member Author

Thanks - sounds a good plan!

@alexlittle alexlittle added this to Backlog in Last Mile Health Jan 4, 2019
@alexlittle alexlittle removed this from Backlog in Last Mile Health Jan 4, 2019
@alexlittle alexlittle added this to Queued for Development in General Development Jan 4, 2019
@alexlittle alexlittle moved this from Queued for Development to For Review in General Development Feb 4, 2019
@alexlittle alexlittle removed this from For Review in General Development Apr 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement medium priority refectoring/review Any areas of code that could be improved/refactored
Projects
None yet
Development

No branches or pull requests

2 participants