Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #14 #15

Merged
merged 1 commit into from Jan 2, 2015
Merged

Fix issue #14 #15

merged 1 commit into from Jan 2, 2015

Conversation

etcimon
Copy link
Contributor

@etcimon etcimon commented May 6, 2014

Issue referenced by #14

This old code caused the new CodeView 4 format to be restrained by the limits from the older formats.

Issue referenced by DigitalMars#14

This old code caused the new CodeView 4 format to be restrained by the limits from the older formats.
@bdeligny
Copy link

bdeligny commented Jun 1, 2014

Please merge this pull request. It's a real pain in the ass for my project (DQuick).

@WalterBright
Copy link
Contributor

I'm worried that removing the check causes some overflow elsewhere in the code, leading to memory corruption. On the other hand, it might simply be a vestige of the 16 bit version of the code.

@WalterBright
Copy link
Contributor

It's always a bit of an adventure changing anything in Optlink due to the lack of a comprehensive test suite. So we'll have to take a chance.

WalterBright added a commit that referenced this pull request Jan 2, 2015
@WalterBright WalterBright merged commit a56c6a6 into DigitalMars:master Jan 2, 2015
@yebblies
Copy link

yebblies commented Jan 2, 2015

You could always make it a warning instead of a hard error. Then at least users would have some indication of where to look if it does produce an invalid/broken exe.

@WalterBright
Copy link
Contributor

The near complete lack of an ability to verify I haven't broken things puts an almost intolerable burden on making fixes to Optlink. I have to be extremely careful, which means tedious and time consuming.

@yebblies
Copy link

yebblies commented Jan 5, 2015

Has the optlink download been updated?

@WalterBright
Copy link
Contributor

I updated the DMC compiler downloads which include the new optlink.

@yebblies
Copy link

yebblies commented Jan 6, 2015

Thanks, what about optlink.zip?

@WalterBright
Copy link
Contributor

just uploaded

@vuaru
Copy link

vuaru commented Jan 7, 2015

Ran into this myself today. (timely!)
Replaced dmd's link.exe with the one in the new dmc download.
Seems to work, will let you know if problems crop up. Thanks.

@WalterBright
Copy link
Contributor

welcs!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants