Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove configuration resources from core module #227

Closed
jnioche opened this issue Dec 17, 2015 · 2 comments
Closed

Remove configuration resources from core module #227

jnioche opened this issue Dec 17, 2015 · 2 comments
Milestone

Comments

@jnioche
Copy link
Contributor

jnioche commented Dec 17, 2015

A new project can be generated using the archetype or by copying the files from there manually. We don't need the config elements in core, these would be specified by the user or generated by the archetype.

Note : crawler-default.yaml would remain in core to provide default values.

This would also fixe #61 as well.

@jnioche jnioche modified the milestone: 0.9 Jan 8, 2016
@jnioche jnioche removed this from the 0.9 milestone Mar 10, 2016
@jnioche
Copy link
Contributor Author

jnioche commented Mar 10, 2016

Removing the configuration files from core causes some tests to fail. Postponing this issue.

jnioche added a commit that referenced this issue Mar 23, 2016
@jnioche jnioche added this to the 0.10 milestone Mar 23, 2016
@jnioche
Copy link
Contributor Author

jnioche commented Mar 23, 2016

Done in #4292e91

core now has no URL or ParseFilters loaded by default, nor does it have an example of Topology. This will prevent confusion about what it used and overridden when building the uber jars.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant