Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Batch PreparedStatements in SQL status updater bolt #610
unfortunately there are no automated tests for the SQL persistence component. That would make working on code improvements so much easier.
In our applications we use the H2 database engine with in memory mode for the tests and PostgreSQL in production. That works pretty fine. For the tests there is no need to setup a database then, which means it can run on every CI server.
Another thing: There are some MySQL specific functions used. I am not 100% sure, but it seems everything needed is pretty basic, so it should be possible to make everything database agnostic and just use plain SQL.
So I'd recommend to get rid of MySQL specifics and have some tests first. What do you think?