New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abstract functionalities of spout implementations #617

Closed
jnioche opened this Issue Sep 29, 2018 · 0 comments

Comments

Projects
None yet
1 participant
@jnioche
Member

jnioche commented Sep 29, 2018

Spouts for SOLR, ES or SQL all have in common that they get URLs from a query, which often will return results already being processed. These spouts keep track of the URLs being processed and in the case of ES, apply a delay after acking to make sure that changes have a chance of being applied to the index before removing the URL from the cache.

This behaviour should go in an abstract class to simplify the code.

@jnioche jnioche changed the title from Abstract caching of URLs processed in spouts to Abstract functionalities of spout implementations Oct 1, 2018

jnioche added a commit that referenced this issue Oct 1, 2018

jnioche added a commit that referenced this issue Oct 2, 2018

Abstract functionalities of spout implementations (#618)
* Abstract functionalities of spout implementations, implements #617

* missing value in conf for solr.status.max.results

* ES Abstract spout must call super.open

@jnioche jnioche closed this Oct 2, 2018

@jnioche jnioche added this to the 1.11 milestone Oct 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment