New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harmonise param names for SQL #619

Closed
jnioche opened this Issue Oct 1, 2018 · 2 comments

Comments

Projects
None yet
1 participant
@jnioche
Member

jnioche commented Oct 1, 2018

Most config keys are prefixed with "mysql." instead we should use "sql" and make the code as implementation neutral as possible.
Would be good to make the configuration of the connection entirely via the conf file and not hardcoded

@jnioche jnioche added the SQL label Oct 1, 2018

@jnioche jnioche added this to the 1.11 milestone Oct 2, 2018

@jnioche

This comment has been minimized.

Member

jnioche commented Oct 2, 2018

This is a first step towards making the SQL module 'implementation neutral' where possible.

@jnioche jnioche closed this in 897e539 Oct 2, 2018

@jnioche

This comment has been minimized.

Member

jnioche commented Oct 2, 2018

The configuration of the connection is now done like this

  sql.connection:
   url: "jdbc:mysql://localhost:3306/crawl"
   user: "myuser"
   password: "mypassword"
   rewriteBatchedStatements: "true"
   useBatchMultiSend: "true"

and is implementation neutral. You can pass key / values specific to the SQL backend used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment