New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FetcherBolts original metadata overwrites metadata returned by protocol #636

Closed
jnioche opened this Issue Oct 17, 2018 · 1 comment

Comments

Projects
None yet
1 participant
@jnioche
Member

jnioche commented Oct 17, 2018

This has an impact e.g. for cookies as any new value returned by the server is ignored if the original metadata already had a value.

@jnioche jnioche added this to the 1.11 milestone Oct 17, 2018

@jnioche jnioche closed this in f94e8e7 Oct 17, 2018

@jnioche

This comment has been minimized.

Member

jnioche commented Oct 17, 2018

We now copy the K/V from the original metadata into a new MD instance then copy the K/V from the protocol output.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment