New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abstract Selenium protocol, NavigationFilters and RemoteDriverProtocol #457

Merged
merged 2 commits into from Apr 24, 2017

Conversation

Projects
None yet
1 participant
@jnioche
Member

jnioche commented Apr 20, 2017

This PR contains much of the code from the jBrowserDriver branch and implements #144. Instead to being tied to a particular library, it provides a neutral RemoteDriverProtocol which can be configured to connect to one or more endpoints.

The code in JBrowserDriver could be refactored later on to be based on this.

There is a lot more work to do on this e.g. pass configuration, setup timeouts etc... but at least this would be a good starting point.

To run with phantomjs on Linux

sudo apt install phantomjs
phantomjs --webdriver 9515

then set in the config:

selenium.addresses: "http://localhost:9515"

@jnioche jnioche merged commit 51ab347 into master Apr 24, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@jnioche jnioche deleted the selenium branch Apr 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment