Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

status update: log error if elastic search reports an unexpected problem #575

Merged
merged 1 commit into from May 28, 2018

Conversation

Projects
None yet
2 participants
@cruftex
Copy link
Contributor

cruftex commented May 28, 2018

Hi Julien,

this PR prints errors, if we get some in the callback from elastic search.
It happened to me that the ES index switched to read-only and I wondered why nothing gets updated, since there is no failure indication.

Cheers,

Jens

@jnioche jnioche added this to the 1.10 milestone May 28, 2018

@jnioche jnioche merged commit 3a66b03 into DigitalPebble:master May 28, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jnioche

This comment has been minimized.

Copy link
Member

jnioche commented May 28, 2018

Thanks @cruftex

jnioche added a commit that referenced this pull request May 28, 2018

jnioche added a commit that referenced this pull request May 28, 2018

@jnioche

This comment has been minimized.

Copy link
Member

jnioche commented May 28, 2018

@cruftex reverted, see comment on #576

@jnioche jnioche removed this from the 1.10 milestone Jun 11, 2018

@jnioche jnioche added this to the 1.11 milestone Jul 10, 2018

jnioche added a commit that referenced this pull request Jul 10, 2018

@jnioche

This comment has been minimized.

Copy link
Member

jnioche commented Jul 10, 2018

Modified and committed. Thanks @cruftex

@cruftex

This comment has been minimized.

Copy link
Contributor Author

cruftex commented Jul 10, 2018

Great! Sorry for not following up on this, too much on my plate at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.