New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URLFilters + ParseFilters refactoring #593

Merged
merged 2 commits into from Jul 18, 2018

Conversation

Projects
None yet
1 participant
@jnioche
Member

jnioche commented Jul 13, 2018

This PR introduces a new interface Configurable which is implemented by both ParseFilter and URLFilter. It also contains code for the wrapper classes URLFilters and ParseFilters so that they share the loading of resources from JSON files. These classes also implement JSONResource.

@jnioche jnioche requested review from jorgelbg and sebastian-nagel Jul 13, 2018

@jnioche jnioche added this to the 1.11 milestone Jul 13, 2018

@jnioche jnioche merged commit 443a120 into master Jul 18, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@jnioche jnioche deleted the Configurable branch Jul 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment