New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StatusMetricsBolt - Added check for avoid NPE when interacting with multi search response #598

Merged
merged 1 commit into from Aug 9, 2018

Conversation

Projects
None yet
2 participants
@jcruzmartini
Contributor

jcruzmartini commented Aug 6, 2018

In order to avoid NPE when there is an exception when doing a multisearch request in StatusMetricsBolt.
We added an extra check in order to guarantee that response is not null.
As you can see in ES java doc of MultiSearchResponse.Item class getResponse() may be null

        /**
         * The actual search response, null if its a failure.
         */
        @Nullable
        public SearchResponse getResponse() {
            return this.response;
        }

@jnioche jnioche added this to the 1.11 milestone Aug 9, 2018

@jnioche jnioche merged commit 4ae9351 into DigitalPebble:master Aug 9, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment