New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrades Xerces, Guava & ElasticSearch #672

Merged
merged 1 commit into from Dec 14, 2018

Conversation

Projects
None yet
2 participants
@jnioche

This comment has been minimized.

Copy link
Member

jnioche commented Dec 13, 2018

Thanks @rzo1.

CookieConverter -> I'd rather update the code to use the new Java Time API instead of the old dates. Can you remove it from this PR so that it is just about dependency updates? We can then revamp the CookieConverter separately, ideally with a unit test. What do you think?

BTW how did your presentation go? any slides or video available online?

@rzo1 rzo1 force-pushed the rzo1:dep-upgrade branch from 4816c7c to 75729d6 Dec 13, 2018

@rzo1 rzo1 changed the title Upgrades Xerces, Guava & ElasticSearch / Fixes test-failure in non-English timezones Upgrades Xerces, Guava & ElasticSearch Dec 13, 2018

@rzo1

This comment has been minimized.

Copy link
Contributor

rzo1 commented Dec 13, 2018

Hey @jnioche

I removed the DATE_PATTERN related stuff from this PR. I agree, that we should re-write this part of the code. SimpleDateFormat is on the one hand not thread-safe and on the other hand it relies - per default - on the default system locale.

Related to the 2nd part of your comment:

The talk (~90min) was for our Master students in (Medical) Computer Science in the context of a lession called "Knowledge Management", which includes topics like NLP, Semantic Web and (Focused) Web-Crawling basics. For them, it was a quite nice experience to get some input from a more practial point of view. I have some slides (but they focus on the research perspective and only a little bit on the technical stuff like SC, Focused Crawling with SC, .. ) - if you are interested, we can find a way to share them or I can upload them on the crawler's info-page.

Show resolved Hide resolved external/elasticsearch/pom.xml Outdated
@jnioche

This comment has been minimized.

Copy link
Member

jnioche commented Dec 13, 2018

if you are interested, we can find a way to share them or I can upload them on the crawler's info-page.

put them on slideshare? can link to it from the Wiki after that

@rzo1 rzo1 force-pushed the rzo1:dep-upgrade branch from 75729d6 to 28af568 Dec 13, 2018

@rzo1

This comment has been minimized.

Copy link
Contributor

rzo1 commented Dec 13, 2018

if you are interested, we can find a way to share them or I can upload them on the crawler's info-page.

put them on slideshare? can link to it from the Wiki after that

I will do this in the next days and sent you a message with the link

@jnioche jnioche added this to the 1.13 milestone Dec 14, 2018

@jnioche jnioche added the dependency label Dec 14, 2018

@jnioche jnioche merged commit 2d7fd2c into DigitalPebble:master Dec 14, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@rzo1 rzo1 deleted the rzo1:dep-upgrade branch Dec 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment