[Bounty] Solana and Serum in Maskbook #1722

yisiliu · 2020-10-14T09:29:29Z

Introduction and Background

Maskbook is designed and developed as a chain agnostic tool, which relies on no chains and in another word, supports all the chains. Currently, Maskbook is focusing on DAPPs on Ethereum but we would like to integrate more chains into our extension to provide users more options. Therefore, we are redesigning our internal wallet into a multi-chain wallet and by the time the new design is finalized, we would like to start integrating new blockchains other than Ethereum.

Content

Solana Wallet

Solana is a scalable and high performance blockchain. We would like to integrate their wallet creation, management and support relevant on-chain operations. Wallet integration is considered as the phase two of this bounty and we are expecting this to start once we release our wallet standard.

Serum UI Integration

Serum is a decentralized on-chain trading platform which supports both orderbook and swap. We would like to integrate its interface in our trader plugin. It allows users to hover their mouse on any token hashtag starting with "$" on Twitter to view its price, trending and a uniswap exchange interface if there is a pair. Integrating Serum, we can support more options other than uniswap so that users could directly trade tokens with Solana without leaving Twitter. This is considered the phase two.

Deadlines

TBD.

gitcoinbot · 2020-10-26T19:48:32Z

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

This issue now has a funding of 5000.0 USDC (5000.0 USD @ $1.0/USDC) attached to it as part of the solana-labs fund.

If you would like to work on this issue you can 'start work' on the Gitcoin Issue Details page.
Want to chip in? Add your own contribution here.
Questions? Checkout Gitcoin Help or the Gitcoin Chat
$916,333.51 more funded OSS Work available on the Gitcoin Issue Explorer

aahutsal · 2020-10-27T18:10:50Z

Why not use the WalletConnect protocol as the base?

yisiliu · 2020-10-28T02:25:26Z

@aahutsal We have already integrated WalletConnect as an option in our internal wallet but we still need to have our own wallet for users who don't have WalletConnect. And, does WalletConnectsupport Solana or any other blockchains? In our new wallet architecture, we are not limited to any specific chain to support all the exciting systems.

Tedko · 2020-10-28T02:29:39Z

Why not use the WalletConnect protocol as the base?

@yisiliu @aahutsal yeah i think WalletConnect dont support SOL or other chain.

aahutsal · 2020-10-28T02:51:20Z

@Tedko @yisiliu by default WalletConnect supports only ETH (aka ERC20) network. But with some modifications we've done for NEO network, it supports non-ERC20. That's how I've found your project request on gitcoin.co and placed my bid there.
Placing my Work Plan here:

Work Plan

Since I've already worked on a similar project for NEO blockchain (proof: https://github.com/aahutsal/neo-walletconnect) I'd warn that you go the wrong path. There's a WalletConnect protocol designed for the mature Ethereum network. There is a bunch of wallets already created that works with WalletConnect protocol with Ethereum and other ERC20 coins. For the NEO network project, my task was to create some architecture that would allow WalletConnect capable wallets to work with non-ERC20 blockchain (NEO), which I've done.

In the repository, you would find the generic architecture described and some dockerized components we use to run NEO blockchain privately. Working code is not submitted due to NDA, of course. I'd basically suggest considering this proposed approach, save your time, monies and get a much better WalletConnect capable engine (which is de-facto the only world standard for now for connecting dApp -> WalletConnect -> Wallet).

yisiliu · 2020-10-28T02:57:22Z

@aahutsal sounds great! My next questions will be 1. does it support all elliptic curves or even RSA(eg Arweave)? and 2. can it run as a local service with a local storage so that users won't need to install WalletConnect wallets? Thank you!

aahutsal · 2020-10-28T03:02:57Z

@yisiliu

Currently it does support only a limited set of requirements NEO network guys requested. But since I see the need for other blockchains in similar integration we might probably start a new project (aka grant) on gitcoin.co, collect funds, gather requirements, and implement all other features requested. Basically it's hardly using code injection (e.g. Provider feature in terms of WalletConnect. Think crypto algorithms could also be injected if we properly implement the architecture.
I've updated my previous comment, please, check it open repo and read diagrams explaining architecture. Actually, it's all you need for now it seems.

yisiliu · 2020-10-28T04:08:19Z

@aahutsal thanks bro! I am quite busy this week but I will try my best to explore your repo and will get back to you soon. I really appreciate your proposal and I am looking forward to our potential cooperation!

aahutsal · 2020-10-28T05:39:04Z

@yisiliu I'm also leaving tomorrow till Monday. Schedule the meeting if you wish here: https://calend.ly/aahutsal

yisiliu · 2020-10-28T06:28:37Z

@aahutsal Booked on Nov 3rd! Thanks.

gitcoinbot · 2020-11-02T03:10:01Z

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Work has been started.

These users each claimed they can complete the work by 266 years from now.
Please review their action plans below:

1) developerfred has been approved to start work.

As a user and admirer of the product, I would love to work on that bounty and enable integration with new portfolios and UIs. Starting with Serum and Solana. I'm excited to start this bounty.
2) aahutsal has been approved to start work.

Since I've already worked on a similar project for NEO blockchain (proof: https://github.com/aahutsal/neo-walletconnect) I'd warn that you go the wrong path.

There's a WalletConnect protocol designed for the mature Ethereum network. There is a bunch of wallets already created that works with WalletConnect protocol with Ethereum and other ERC20 coins.

For the NEO network project, my task was to create some architecture that would allow WalletConnect capable wallets to work with non-ERC20 blockchain (NEO), which I've done. In the repository, you would find the generic architecture described and some dockerized components we use to run NEO blockchain privately.

Working code is not submitted due to NDA, of course. I'd basically suggest considering this proposed approach, save your time, monies and get a much better WalletConnect capable engine (which is de-facto the only world standard for now for connecting dApp -> WalletConnect -> Wallet).

Learn more on the Gitcoin Issue Details page.

gitcoinbot · 2020-11-02T03:10:03Z

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Work has been started.

These users each claimed they can complete the work by 264 years, 6 months from now.
Please review their action plans below:

1) developerfred has been approved to start work.

As a user and admirer of the product, I would love to work on that bounty and enable integration with new portfolios and UIs. Starting with Serum and Solana. I'm excited to start this bounty.
2) ult-processor has been approved to start work.

I really admire this project and I will like to contribute to it.

Learn more on the Gitcoin Issue Details page.

aahutsal · 2020-11-03T07:41:00Z

@aahutsal Booked on Nov 3rd! Thanks.

@yisiliu thanks for approval. Unfortunately, I have been late for a meeting that been scheduled 30 mins ago. Can we reschedule for today afternoon?

yisiliu · 2020-11-03T07:46:03Z

@aahutsal yes I did email you for the link lol. I am not sure if I am gonna make it this afternoon. Can we do it tomorrow afternoon?

aahutsal · 2020-11-03T07:50:29Z

sure, tomorrow would work for me

aahutsal · 2020-11-03T08:24:08Z

@aahutsal yes I did email you for the link lol. I am not sure if I am gonna make it this afternoon. Can we do it tomorrow afternoon?

Please, schedule yourself: https://calendly.com/ahutsal

aahutsal · 2020-11-03T08:24:58Z

@aahutsal yes I did email you for the link lol. I am not sure if I am gonna make it this afternoon. Can we do it tomorrow afternoon?

Okay. You booked Friday. Would work for me. Tty then.

yisiliu · 2020-11-03T08:36:46Z

@aahutsal That wasn't me. I just booked tomorrow.

aahutsal · 2020-11-03T15:15:03Z

@aahutsal That wasn't me. I just booked tomorrow.

My bad. That was not you :) See you've booked tomorrow. Talk then.

aahutsal · 2020-11-05T06:29:41Z

@yisiliu could you please clarify how many "new blockchains other than Ethereum" should be integrated with the scope of a current project?

yisiliu · 2020-11-05T08:41:31Z

@aahutsal for now we are looking at: Ethereum, Polkadot and its parachains, Solana, NEAR, and Arweave(quite different tbh).

aahutsal · 2020-11-06T09:30:30Z

By Ethereum you mean Ethereum only, or all ERC20/ERC721? It's quite a lot, @yisiliu !

developerfred · 2020-11-08T18:49:23Z

@yisiliu and @Tedko What is the Maskbook Solana wallet for fee for swaps made on twitter?

Tedko · 2020-11-09T05:39:32Z

By Ethereum you mean Ethereum only, or all ERC20/ERC721? It's quite a lot, @yisiliu !

For Ethereum it will be a full useable wallet for our mask.io internal wallet. That include erc20/721; try the latest ones you can actually see we already have 721 beta.

aahutsal · 2020-11-17T11:33:27Z

@Tedko @yisiliu I'm working on docker-compose that's intended to run all nodes for blockchains listed (Ethereum, Polkadot, Solana, NEAR, and Arweave). My PIXELBOOK 2019 with 16GB RAM gets slow running all of that. Besides that - it would take ages and gigabytes to sync nodes running.

I think we should consider moving these nodes to some public IP and probably scaling them horizontally (similar to what Infura.io does for Ethereum) - which would be a must for your wallet (which is a browser extension by design). That's going to be a separate service. I can consider participation.

developerfred · 2020-11-17T11:38:12Z

@aahutsal try use gitpod.io for running your nodes.

aahutsal · 2020-11-17T12:15:04Z

@aahutsal try use gitpod.io for running your nodes.

Thanks, @developerfred . I'll ask you once I need your assistance.

aahutsal · 2020-12-25T11:17:18Z

@yisiliu thank you ;) Silly me - slept for 2 hrs only 👍

aahutsal · 2020-12-25T15:51:31Z

I've hit problems running Solana build in dev mode (with rust installed). Created issue in solana-web3.js/#1008

aahutsal · 2020-12-25T15:51:55Z

You can put the box down for now, if it's costly

aahutsal · 2020-12-28T13:53:16Z

@yisiliu can you please attach one more SSD device for 80Gb at the least?
There's no room on / partition it seems even to build Solana. I've already avoided solana-web3.js/#1008 bug reported to them before.

yisiliu · 2020-12-29T07:46:08Z

@aahutsal sorry about the late - I have extended the disk space to 160GB. Check it now.

aahutsal · 2020-12-29T12:53:15Z

Thanks. That's enough!

aahutsal · 2021-01-04T09:23:51Z

@yisiliu @Tedko could someone open me 3376, 2377 ipv4/ipv6 TCP ports on AWS firewall? Needed for docker swarm and docker-machine. For security reasons it's better to run openvpn to access that box, but... would you bother with it? If so - open 1194 port (UDP) and lemme know. I'll setup openvpn server and share the .opvn file with you.

yisiliu · 2021-01-04T09:34:57Z

@aahutsal fair enough - expect it to be done in 5 mins

aahutsal · 2021-01-04T09:35:28Z

thx @yisiliu For now I'm using SSH tunneling ;)

yisiliu · 2021-01-04T09:44:18Z

Custom TCP | TCP | 3376 | 0.0.0.0/0
Custom TCP | TCP | 2377 | 0.0.0.0/0

@aahutsal done

aahutsal · 2021-01-04T10:11:17Z

already saw it and successfully joined the swarm, thx

aahutsal · 2021-01-04T11:57:27Z

@yisiliu trader plugin link is broken in Serum task description.

Although it's phase II, could you please point me there?

yisiliu · 2021-01-04T12:22:30Z

@aahutsal https://github.com/DimensionDev/Maskbook/tree/master/packages/maskbook/src/plugins/Trader

aahutsal · 2021-01-05T09:49:52Z

@yisiliu @Tedko @septs
Please, also open 8899, 8900 ports for direct solana-validator access and 1194 UDP port for OpenVPN

Would also need that:

[default]
aws_access_key_id = MY-ACCESS-KEY-ID
aws_secret_access_key = MY-SECRET-KEY

gitcoinbot · 2021-01-06T13:41:15Z

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Work for 5000.0 USDC (5000.00 USD @ $1.0/USDC) has been submitted by:

Learn more on the Gitcoin Issue Details page
Want to chip in? Add your own contribution here.
Questions? Checkout Gitcoin Help or the Gitcoin Chat
$944,964.34 more funded OSS Work available on the Gitcoin Issue Explorer

aahutsal · 2021-01-12T06:46:57Z

@yisiliu could you confirm ports will be opened and could you share AWS access key with me, so I can easily manage AWS node dedicated for that project (you can create an AWS access key with restricted access for that purpose).

Also, check your email. Ason seems keeping quiet.

aahutsal · 2021-02-01T23:26:44Z

@yisiliu could you please answer me via email or here?

aahutsal · 2021-02-26T11:29:07Z

@yisiliu could you check the email I sent?

Tedko · 2021-06-18T19:16:24Z

hey guys @aahutsal @yisiliu any updates?

aahutsal · 2021-06-20T13:32:38Z

@Tedko should I speak to you directly now, or keep working with @yisiliu ?

aahutsal · 2021-07-05T12:13:05Z

@Tedko could you please reply my email I sent like 2+ weeks ago?

Tedko · 2021-07-13T13:42:01Z

will loop in @tzhan28 in case we're not responding here @aahutsal :)

aahutsal · 2021-08-03T14:32:35Z

@yisiliu @Tedko Meeting is over, seems I've shown everything we have by now. Now I need to contact of the guy who is working on UI for v2.0

aahutsal · 2021-08-06T12:26:23Z

@guanbinrui Could we please talk on Discord about UI additions for v2.0? I've already sent you DM

yisiliu added the Bounty: Finished label Oct 14, 2020

Tedko mentioned this issue Oct 19, 2020

[Task] Multi-blockchain wallet support research #1547

Closed

developerfred mentioned this issue Nov 14, 2020

feat: add solana network and serum/swap #1908

Closed

3 tasks

This comment has been minimized.

Sign in to view

This was referenced Oct 17, 2021

feat: Solana Foundation #4607

Merged

refactor: EVM & Wallet plugin #4628

Closed

refacotr: EVM & Wallet #4639

Closed

Tedko closed this as completed May 16, 2022

[Bounty] Solana and Serum in Maskbook #1722

[Bounty] Solana and Serum in Maskbook #1722

Comments

yisiliu commented Oct 14, 2020

Introduction and Background

Content

Solana Wallet

Serum UI Integration

Deadlines

gitcoinbot commented Oct 26, 2020

aahutsal commented Oct 27, 2020

yisiliu commented Oct 28, 2020 • edited Loading

Tedko commented Oct 28, 2020

aahutsal commented Oct 28, 2020 • edited Loading

yisiliu commented Oct 28, 2020

aahutsal commented Oct 28, 2020 • edited Loading

yisiliu commented Oct 28, 2020

aahutsal commented Oct 28, 2020 • edited Loading

yisiliu commented Oct 28, 2020

gitcoinbot commented Nov 2, 2020

gitcoinbot commented Nov 2, 2020 • edited Loading

aahutsal commented Nov 3, 2020

yisiliu commented Nov 3, 2020

aahutsal commented Nov 3, 2020

aahutsal commented Nov 3, 2020

aahutsal commented Nov 3, 2020

yisiliu commented Nov 3, 2020

aahutsal commented Nov 3, 2020

aahutsal commented Nov 5, 2020

yisiliu commented Nov 5, 2020

aahutsal commented Nov 6, 2020 • edited Loading

developerfred commented Nov 8, 2020 • edited Loading

Tedko commented Nov 9, 2020

aahutsal commented Nov 17, 2020 • edited Loading

developerfred commented Nov 17, 2020

aahutsal commented Nov 17, 2020

This comment has been minimized.

This comment has been minimized.

aahutsal commented Dec 25, 2020 • edited Loading

aahutsal commented Dec 25, 2020 • edited Loading

aahutsal commented Dec 25, 2020

aahutsal commented Dec 28, 2020

yisiliu commented Dec 29, 2020

aahutsal commented Dec 29, 2020

aahutsal commented Jan 4, 2021 • edited Loading

yisiliu commented Jan 4, 2021

aahutsal commented Jan 4, 2021

yisiliu commented Jan 4, 2021

aahutsal commented Jan 4, 2021

aahutsal commented Jan 4, 2021

yisiliu commented Jan 4, 2021

aahutsal commented Jan 5, 2021 • edited Loading

gitcoinbot commented Jan 6, 2021

aahutsal commented Jan 12, 2021

aahutsal commented Feb 1, 2021

aahutsal commented Feb 26, 2021

Tedko commented Jun 18, 2021

aahutsal commented Jun 20, 2021

aahutsal commented Jul 5, 2021

Tedko commented Jul 13, 2021 • edited Loading

aahutsal commented Aug 3, 2021

aahutsal commented Aug 6, 2021

yisiliu commented Oct 28, 2020 •

edited

Loading

aahutsal commented Oct 28, 2020 •

edited

Loading

aahutsal commented Oct 28, 2020 •

edited

Loading

aahutsal commented Oct 28, 2020 •

edited

Loading

gitcoinbot commented Nov 2, 2020 •

edited

Loading

aahutsal commented Nov 6, 2020 •

edited

Loading

developerfred commented Nov 8, 2020 •

edited

Loading

aahutsal commented Nov 17, 2020 •

edited

Loading

aahutsal commented Dec 25, 2020 •

edited

Loading

aahutsal commented Dec 25, 2020 •

edited

Loading

aahutsal commented Jan 4, 2021 •

edited

Loading

aahutsal commented Jan 5, 2021 •

edited

Loading

Tedko commented Jul 13, 2021 •

edited

Loading