Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove redundant await #8286

Merged
merged 1 commit into from Dec 15, 2022
Merged

refactor: remove redundant await #8286

merged 1 commit into from Dec 15, 2022

Conversation

guanbinrui
Copy link
Member

@guanbinrui guanbinrui commented Dec 15, 2022

Description

Closes # (NO_ISSUE)

Type of change

  • Documentation
  • Code refactoring (Restructuring existing code w/o changing its observable behavior)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (a fix or feature that would make something no longer possible to do/require old user must upgrade their Mask Network to this new version)

Previews

Checklist

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
    • I have removed all in development console.logs
    • I have removed all commented code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have read Internationalization Guide and moved text fields to the i18n JSON file.

If this PR depends on external APIs:

  • I have configured those APIs with CORS headers to let extension requests get passed.
    • chrome extension: chrome-extension://[id]
    • firefox extension: moz-extension://[id]
  • I have delegated all web requests to the background service via the internal RPC bridge.

@guanbinrui guanbinrui marked this pull request as ready for review December 15, 2022 09:05
@guanbinrui guanbinrui added this to the 2.17.0 milestone Dec 15, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Dec 15, 2022

@github-actions github-actions bot temporarily deployed to pull request December 15, 2022 09:09 Inactive
@guanbinrui guanbinrui changed the title refactor: remove await refactor: remove redundant await Dec 15, 2022
@guanbinrui guanbinrui merged commit d078bcf into develop Dec 15, 2022
@guanbinrui guanbinrui deleted the refactor/code-style branch December 15, 2022 09:19
@github-actions github-actions bot temporarily deployed to pull request December 15, 2022 09:20 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant