Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: nft project bugs #8426

Merged
merged 4 commits into from Jan 9, 2023
Merged

fix: nft project bugs #8426

merged 4 commits into from Jan 9, 2023

Conversation

zhouhanseng
Copy link
Contributor

Description

https://mask.atlassian.net/browse/MF-3142
https://mask.atlassian.net/browse/MF-3141
https://mask.atlassian.net/browse/MF-3104
https://mask.atlassian.net/browse/MF-3032

Closes # (NO_ISSUE)

Type of change

  • Documentation
  • Code refactoring (Restructuring existing code w/o changing its observable behavior)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (a fix or feature that would make something no longer possible to do/require old user must upgrade their Mask Network to this new version)

Previews

Checklist

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
    • I have removed all in development console.logs
    • I have removed all commented code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have read Internationalization Guide and moved text fields to the i18n JSON file.

If this PR depends on external APIs:

  • I have configured those APIs with CORS headers to let extension requests get passed.
    • chrome extension: chrome-extension://[id]
    • firefox extension: moz-extension://[id]
  • I have delegated all web requests to the background service via the internal RPC bridge.

@zhouhanseng zhouhanseng added this to the 2.17.0 milestone Jan 9, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2023

@github-actions github-actions bot temporarily deployed to pull request January 9, 2023 06:43 Inactive
@guanbinrui guanbinrui merged commit c75795e into develop Jan 9, 2023
@guanbinrui guanbinrui deleted the fix-nft-project-bugs branch January 9, 2023 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants