Fix retain cycle and VM recreation #275
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR addresses two issues with the
VillagersViewModel
. In particular with its recreation whenever SwiftUI dictates so and the implicit use ofself
as part of its implementation.How
self
weak and avoid themap
's closure capturingself
.StateObject
instead ofObservedObject
. Although I am not particular fond of this approach, it fixes the problem whereVillagersViewModel
is being recreated every time the user switches tab onTodayBirthdaysSection
.This problem can be seen here:
We can also see the memory growing with the implicit
self
capture: