Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat (desktop): upgrade from wry 37 to 41 #2618

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

imgurbot12
Copy link
Contributor

In my playing around with dioxus to resolve an issue with wry, I toyed with upgrading to the latest version: v0.41.0
I'm not sure if it changed anything for me yet, but I figured it might be useful for the project so I've made a PR for it.

Hopefully its helpful somehow :)

@imgurbot12
Copy link
Contributor Author

imgurbot12 commented Jul 10, 2024

For the sake of fun metrics, after more testing, jumping from v37 to v41 made about a 400ms improvement in time to the initial render after repeated testing using my own personal project. Not faster than v28 still for some reason but much improved.

@ealmloff ealmloff added desktop Suggestions related to the desktop renderer dependencies Pull requests that update a dependency file labels Jul 10, 2024
Copy link
Member

@jkelleyrtp jkelleyrtp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much smaller diff than I expected, thanks!

@jkelleyrtp jkelleyrtp merged commit 69d7098 into DioxusLabs:main Jul 10, 2024
5 of 10 checks passed
@imgurbot12 imgurbot12 deleted the feat/wry-41 branch July 10, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file desktop Suggestions related to the desktop renderer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants