fix(rsx): formatted attribute merging #3719
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sehnryr
force-pushed
the
fix/merge-formatted-attributes
branch
from
7d3bc10 to
703d46f
Compare
jkelleyrtp
approved these changes
Apr 15, 2025
AnteDeliria
pushed a commit
to AnteDeliria/dioxus
that referenced
this pull request
Jun 2, 2025
* test(rsx): add better tests for attributes merging * fix(rsx): zero-lengthed source with non-empty segments is non-trivial * refactor(rsx): use `is_empty` instead of `len() == 0` (clippy) * fix(rsx): different asserts whether in release or not
AnteDeliria
pushed a commit
to AnteDeliria/dioxus
that referenced
this pull request
Jul 23, 2025
* test(rsx): add better tests for attributes merging * fix(rsx): zero-lengthed source with non-empty segments is non-trivial * refactor(rsx): use `is_empty` instead of `len() == 0` (clippy) * fix(rsx): different asserts whether in release or not
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When attributes are merged in
Element::merge_attributes,out'ssourceis not updated (I don't know if it should) and even if the segments are trivial, sincesourceis empty we cannot consider it as a "simple expression" byis_simple_expr.This would result in an issue when merging the following classes with me output being empty:
I also modified the
merges_attributestest splitting it into different cases:merge_trivial_attributes: merge between two literalsmerge_formatted_attributes: merge between a literal and a formattedmerge_conditional_attributes: merge between a literal and two conditionalsmerge_all_attributes: merge between all of the above