fix: symbol mismatch in object file #4171
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsgallups
commented
May 22, 2025
There was a problem hiding this comment.
I am sure this PR is amiss in other places for a few reasons
- I'm unsure if this is
moldspecific behavior - I cannot find a reference for how rust gives equivalency between
STT_FUNCandSTT_TLS - I cannot reproduce on windows due to #4159, and I will only have access to mac in the AM to make sure this is inconsequential/beneficial.
Did not update the comment for the SymbolKind::Text arm
|
I think we can use the section of the symbol to determine which type of TLS it is. We do need both. Will take a poke at fixing it for the STT type. Do you have any projects or repro that includes both? |
|
@jkelleyrtp Would it still be beneficial to have an MRE? |
AnteDeliria
pushed a commit
to AnteDeliria/dioxus
that referenced
this pull request
Jun 2, 2025
* fix: symbol kind in obj * actually patch TLS * update docs and cleanup size impl for tls * remove debug logs --------- Co-authored-by: Jonathan Kelley <jkelleyrtp@gmail.com>
AnteDeliria
pushed a commit
to AnteDeliria/dioxus
that referenced
this pull request
Jul 23, 2025
* fix: symbol kind in obj * actually patch TLS * update docs and cleanup size impl for tls * remove debug logs --------- Co-authored-by: Jonathan Kelley <jkelleyrtp@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4169