New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ASM Patcher so that it uses the ARM9 RAM Address specific to each game defined at 0x28 in the ROM header instead of the hardcoded value used by NSMB. #20

Merged
merged 1 commit into from Aug 2, 2014

Conversation

Projects
None yet
2 participants
@Fiachra1993
Contributor

Fiachra1993 commented Jul 31, 2014

The 'Run make and insert' feature currently assumes that the ARM9 RAM address is 0x02000000 as in NSMB for all NDS games, however each game's will vary, for example in SM64DS (E) it's 0x02004000 and trying to use the ASM Patcher with these games will not work. Changing it so that it uses the value at 0x28 in the ROM header allows the ASM Patcher to work with games with different ARM9 RAM addresses, eg. SM64DS is now compatible.

Update ASM Patcher so that it uses the ARM9 RAM Address specific to e…
…ach game defined at 0x28 in the ROM header instead of the hardcoded value used by NSMB.
@Dirbaio

This comment has been minimized.

Show comment
Hide comment
@Dirbaio

Dirbaio Aug 2, 2014

Owner

SM64DS's ARM binary starts at 0x02004000 indeed, wow. I thought all games compiled with Nintendo devkit start at 0x02000000.

Thanks for the PR :D

Owner

Dirbaio commented Aug 2, 2014

SM64DS's ARM binary starts at 0x02004000 indeed, wow. I thought all games compiled with Nintendo devkit start at 0x02000000.

Thanks for the PR :D

Dirbaio added a commit that referenced this pull request Aug 2, 2014

Merge pull request #20 from Fiachra1993/master
Update ASM Patcher so that it uses the ARM9 RAM Address specific to each game defined at 0x28 in the ROM header instead of the hardcoded value used by NSMB.

@Dirbaio Dirbaio merged commit 16fcab8 into Dirbaio:master Aug 2, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment