Add methods for getting, editing, and deleting a message via webhook. #1026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Modify channel hierarchy in preparation for threads * Use 'TopLevel' names instead of temp names, remove duplicate docs * Add deprecation docs * Add class docs * Make CategorizableChannel extend TopLevelGuildChannel * Make breaking channel hierarchy changes * (Re)move methods deprecated in preparation for threads * Move most base channel method implementations to default methods * Remove most base channel classes * Don't deprecate GuildChannel#getEffectivePermissions * Remove BaseTopLevelGuildChannel, add license headers, docs * Remove unused imports * Remove unused imports Co-authored-by: quanticc <abarcab.ivan@gmail.com>
* Initial work on threads * More work on threads * Modify channel hierarchy in preparation for threads * Use 'TopLevel' names instead of temp names, remove duplicate docs * Add deprecation docs * Add class docs * Make CategorizableChannel extend TopLevelGuildChannel * Make breaking channel hierarchy changes * (Re)move methods deprecated in preparation for threads * Move most base channel method implementations to default methods * Remove most base channel classes * Don't deprecate GuildChannel#getEffectivePermissions * Remove BaseTopLevelGuildChannel, add license headers, docs * Remove unused imports * Remove unused imports * Use new channel hierarchy
Add spec/mono generators for editing and deleting a message via webhook. Add new interface VoidSpec that provides a default implementation of asRequest that returns null.
Remove WebhookMessageDeleteSpecGenerator.java Add Webhook#executeMessageGet
NovaFox161
requested changes
Oct 12, 2021
core/src/main/java/discord4j/core/spec/WebhookMessageDeleteSpecGenerator.java
Outdated
Show resolved
Hide resolved
core/src/main/java/discord4j/core/spec/WebhookMessageEditSpecGenerator.java
Show resolved
Hide resolved
j0rdanit0
changed the title
quanticc
added
area/core
quanticc
requested changes
Oct 23, 2021
|
@quanticc thanks, the method names have been updated now. Should the name of WebhookMessageEditSpec and Mono be updated as well? To WebhookEditMessageSpec and Mono |
|
Dang I merged master in. I'll revert that tomorrow when I'm not on my phone lol |
quanticc
added a commit
that referenced
this pull request
Nov 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Adds 3 missing helper methods in the
Webhookclass:getMessage()editMessage()deleteMessage()Adds
WebhookMessageEditSpecGeneratorandWebhookMessageEditMonoGeneratorto support new methodsJustification:
These documented routes already exist in the
WebhookService, but have not yet been added to theWebhookclass for easier execution.Note:
When creating the spec/mono generator, I may have broken some conventions, so please advise any changes I should make. Particularly for this reason:
Webhook#editMessageaccept themessageIdas a required parameter, separately from theWebhookMessageEditSpec, since the call will not work without one? As it is now, the messageId has to be set in the spec, and then it is validated to be non-null upon execution. Or, because messageId is a path variable rather than a member of the request body, should it even be included in the spec at all? For example, the 2 webhook fields aren't included in the spec.Thanks for your consideration.