Make breaking channel hierarchy changes #960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* (Re)move methods deprecated in preparation for threads * Move most base channel method implementations to default methods * Remove most base channel classes
darichey
added
area/core
|
For now, this is based on |
skykatik
pushed a commit
to skykatik/Discord4J
that referenced
this pull request
Oct 3, 2021
* Modify channel hierarchy in preparation for threads * Use 'TopLevel' names instead of temp names, remove duplicate docs * Add deprecation docs * Add class docs * Make CategorizableChannel extend TopLevelGuildChannel * Make breaking channel hierarchy changes * (Re)move methods deprecated in preparation for threads * Move most base channel method implementations to default methods * Remove most base channel classes * Don't deprecate GuildChannel#getEffectivePermissions * Remove BaseTopLevelGuildChannel, add license headers, docs * Remove unused imports * Remove unused imports Co-authored-by: quanticc <abarcab.ivan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Following #959, remove deprecated methods and make breaking changes in preparation for threads. These changes are summarized by the following class diagrams.
Changes in this PR (3.3.0)
Final (3.3.0)
This is exactly the same as the one above, except the diff information has been removed and things have been rearranged more nicely.
Now,
ThreadChannelcan implementGuildMessageChannel.This PR also moves almost all of the channel method implementations to the interfaces themselves as default methods. This makes the diff quite large, but I found this to be the easiest way to implement the required changes. Specifically,
getEffectivePermissionsis now "actually" abstract, in that it will have a different implementation for different channel types. None of the other channel methods are like this. They are abstract only to enable code sharing. This "actually abstract" method broke our previous strategy of BaseXChannel delegate classes, because they can't be instantiated anymore.