Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travel bug #659

Closed
tyler489 opened this issue Apr 28, 2018 · 7 comments
Assignees

Comments

@tyler489
Copy link

@tyler489 tyler489 commented Apr 28, 2018

Please describe your issue below.
When traveling from a location that allows #!adv to a location that doesnt (silverfall alter) doing #!adv will allow you to adventure once in that location

If you have 1 screenshot or more for context of the issue, please insert into the brackets below.

@PlayTheFallen

This comment has been minimized.

Copy link
Member

@PlayTheFallen PlayTheFallen commented Apr 28, 2018

This issue would occur at any location that had adventures, sides, market disabled or if a user's previous location had any of these disabled.

@tyler489

This comment has been minimized.

Copy link
Author

@tyler489 tyler489 commented Apr 28, 2018

if the location you are traveling from does not have mineing the same thing happens.. but it just says you cant mine here https://gyazo.com/1ba63ee620c3c5d8ca771a0bb649dd71 this also triggers the skill cooldown of 5 min.

@PlayTheFallen

This comment has been minimized.

Copy link
Member

@PlayTheFallen PlayTheFallen commented Apr 30, 2018

the cooldown bit is hard coded into the message handler, even if we were to try and reverse it's affect it would be too early to do such unless of course the whole bot is rewritten to improve performance, which i do not see happening any time soon :/

@tyler489

This comment has been minimized.

Copy link
Author

@tyler489 tyler489 commented May 5, 2018

I feel like you could add a did fail flag of some kind assigned to a simple check of the msg handler. If it failed then set the cool down to 0. But i dont know if thats possible or not. Just a theory

@lifeofchrome

This comment has been minimized.

Copy link

@lifeofchrome lifeofchrome commented May 29, 2018

^ I'm sorry I was trying to play around with GitHub issues and used this as a test and messed up twice in a row. Disregard.

@lifeofchrome

This comment has been minimized.

Copy link

@lifeofchrome lifeofchrome commented May 29, 2018

And I just clicked the wrong button. facepalm

@tyler489

This comment has been minimized.

Copy link
Author

@tyler489 tyler489 commented May 29, 2018

Well done :)

@Snazzah Snazzah added the in progress label Nov 7, 2018
@Sven65 Sven65 added Review and removed in progress labels Nov 9, 2018
@Sven65 Sven65 closed this Nov 27, 2018
@Sven65 Sven65 added Awaiting Push and removed Review labels Nov 27, 2018
@Sven65 Sven65 removed the Awaiting Push label Dec 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.