Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to trade incomplete socketed items #794

Closed
myrissa opened this issue Jan 25, 2019 · 2 comments
Closed

Unable to trade incomplete socketed items #794

myrissa opened this issue Jan 25, 2019 · 2 comments
Assignees
Labels
Bug

Comments

@myrissa
Copy link

@myrissa myrissa commented Jan 25, 2019

When donating an item if it does not have all sockets it will keep telling you that it didn't find the item even though it does. see attached.
image

User should be able to put correct item in quotes to stop the bot from trying to look for a diff name. Even tested without the # same issue. Please fix this as it is sometimes necesary to trade items that is just 2S or 2SJ etc. Also if we were able to put the "complete" name in a bracket or quotes it would resolve the issue with the bot thinking there are multiples when it comes to the 2s or +7 etc. Thanks!!!

image

@Willard21

This comment has been minimized.

Copy link

@Willard21 Willard21 commented Jan 25, 2019

As Matthew suggested, the issue is with the 2. Some incorrect regex treats any numbers in the name as the amount, then removes them from the search. Since there's no exact matches for the item since its full name isn't checked, it treats it like a partial match and gives multiple results. Since axe is contained within pickaxe, the workaround of using the partial match (by leaving the number off) won't work as it does for other items.

gdepitem and gwditem, or passing it through the market should work (but be careful using the market since it goes public for a second).

@Willard21

This comment has been minimized.

Copy link

@Willard21 Willard21 commented Jan 25, 2019

Ooooo actually, I think you can trick the regex into working if you do something like 1iron axe 2sj so it'll cut out the 1 as the amount instead of the 2.

@Willard21 Willard21 added the Bug label Jan 29, 2019
@Willard21 Willard21 self-assigned this Jan 30, 2019
@Willard21 Willard21 added the Review label Jan 30, 2019
@Willard21 Willard21 closed this Feb 6, 2019
@Willard21 Willard21 added Awaiting Push and removed Review labels Feb 6, 2019
@Sven65 Sven65 removed the Awaiting Push label Feb 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.