Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Joining guild error (add role issue) #796

Closed
FelixArgyle opened this issue Jan 28, 2019 · 1 comment
Closed

Joining guild error (add role issue) #796

FelixArgyle opened this issue Jan 28, 2019 · 1 comment
Assignees
Labels
Bug

Comments

@FelixArgyle
Copy link

@FelixArgyle FelixArgyle commented Jan 28, 2019

Describe the bug
Phoenix Heart is an old guild that used to have a guild role within the Discord Dungeons server, as there were too many roles in the main server causing us to clean inactive guild roles, Phoenix Heart was caught up with the clean and their guild role was removed, as far as I'm aware Mackan mentioned that he removed them having an active guild role from the database aswell as refunded the costs to all guilds that had their role removed, not sure why this error will exist as their guild role should've been removed from the database 🤔

To Reproduce
Steps to reproduce the behavior:

  1. #!gjoin Phoenix Heart
  2. You will see the error mentioned shown below.
TypeError: Cannot read property 'length' of null
    at Gjoin._addRoles (/home/mackan/RPGBot/src/Commands/Commands/Guild/Gjoin.js:87:12)
    at Gjoin._joinGuild (/home/mackan/RPGBot/src/Commands/Commands/Guild/Gjoin.js:114:15)
    at <anonymous>
    at process._tickDomainCallback (internal/process/next_tick.js:228:7)

Expected behavior
I expect this error to not appear.
Screenshots
4f0956

Version
DRPG Version 4.7.0

Additional context
Many guild roles were removed due to a clean that happened in the Discord Dungeon's server due to the server reaching the role capacity, so there'd be many other guilds that if you join this error may show.

@Willard21

This comment has been minimized.

Copy link

@Willard21 Willard21 commented Jan 28, 2019

Looks like he must have set the roles to null in the database, but only checks for undefined in the code. Easy fix.

@Willard21 Willard21 added the Bug label Jan 31, 2019
@Willard21 Willard21 self-assigned this Jan 31, 2019
@Willard21 Willard21 closed this Feb 6, 2019
@Willard21 Willard21 added Awaiting Push and removed Review labels Feb 6, 2019
@Sven65 Sven65 removed the Awaiting Push label Feb 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.