From d87a386505df081a35499c554c58a2accdad98c5 Mon Sep 17 00:00:00 2001 From: sid597 Date: Sun, 23 Mar 2025 13:12:47 +0530 Subject: [PATCH 1/9] use switches instead of checkbox --- .../roam/src/components/settings/HomePersonalSettings.tsx | 8 ++++---- apps/roam/src/components/settings/QuerySettings.tsx | 4 ++-- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/apps/roam/src/components/settings/HomePersonalSettings.tsx b/apps/roam/src/components/settings/HomePersonalSettings.tsx index 9251b7bc6..46dd79c52 100644 --- a/apps/roam/src/components/settings/HomePersonalSettings.tsx +++ b/apps/roam/src/components/settings/HomePersonalSettings.tsx @@ -1,6 +1,6 @@ import React from "react"; import { OnloadArgs } from "roamjs-components/types"; -import { Label, Checkbox } from "@blueprintjs/core"; +import { Label, Switch } from "@blueprintjs/core"; import Description from "roamjs-components/components/Description"; import { NodeMenuTriggerComponent } from "../DiscourseNodeMenu"; import { @@ -24,7 +24,7 @@ const HomePersonalSettings = ({ onloadArgs }: { onloadArgs: OnloadArgs }) => { /> - { } /> - { } /> - { const target = e.target as HTMLInputElement; diff --git a/apps/roam/src/components/settings/QuerySettings.tsx b/apps/roam/src/components/settings/QuerySettings.tsx index 988680dc2..4a0305ba8 100644 --- a/apps/roam/src/components/settings/QuerySettings.tsx +++ b/apps/roam/src/components/settings/QuerySettings.tsx @@ -1,6 +1,6 @@ import React from "react"; import { OnloadArgs } from "roamjs-components/types"; -import { Label, NumericInput, Checkbox } from "@blueprintjs/core"; +import { Label, NumericInput, Switch } from "@blueprintjs/core"; import Description from "roamjs-components/components/Description"; import { getSettings } from "~/utils/parseResultSettings"; import { DEFAULT_PAGE_SIZE_KEY, HIDE_METADATA_KEY } from "~/data/userSettings"; @@ -15,7 +15,7 @@ const QuerySettings = ({ const { globalPageSize } = getSettings(extensionAPI); return (
- { const target = e.target as HTMLInputElement; From 8dbf51c81c9d7abf33af584d74f1df974c9b04bc Mon Sep 17 00:00:00 2001 From: sid597 Date: Sun, 23 Mar 2025 13:26:09 +0530 Subject: [PATCH 2/9] align attribute inputgroup and button --- .../settings/DiscourseNodeAttributes.tsx | 52 +++++++++---------- 1 file changed, 26 insertions(+), 26 deletions(-) diff --git a/apps/roam/src/components/settings/DiscourseNodeAttributes.tsx b/apps/roam/src/components/settings/DiscourseNodeAttributes.tsx index d237b46be..49cbc8b90 100644 --- a/apps/roam/src/components/settings/DiscourseNodeAttributes.tsx +++ b/apps/roam/src/components/settings/DiscourseNodeAttributes.tsx @@ -84,36 +84,36 @@ const NodeAttributes = ({ uid }: { uid: string }) => { /> ))}
-
-
); From 4b76b50d8d1b70637ed46cdc0409bb70cee0ef2c Mon Sep 17 00:00:00 2001 From: sid597 Date: Sun, 23 Mar 2025 13:40:40 +0530 Subject: [PATCH 3/9] fix default filters --- apps/roam/src/components/settings/DefaultFilters.tsx | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/apps/roam/src/components/settings/DefaultFilters.tsx b/apps/roam/src/components/settings/DefaultFilters.tsx index 4868401fd..d96761d06 100644 --- a/apps/roam/src/components/settings/DefaultFilters.tsx +++ b/apps/roam/src/components/settings/DefaultFilters.tsx @@ -179,15 +179,15 @@ const DefaultFilters = ({ }} /> ))} -
+
setNewColumn(e.target.value)} />
- +
+ +
Date: Thu, 27 Mar 2025 17:36:39 +0530 Subject: [PATCH 5/9] use checkbox instead of switches --- .../roam/src/components/settings/HomePersonalSettings.tsx | 8 ++++---- apps/roam/src/components/settings/QuerySettings.tsx | 4 ++-- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/apps/roam/src/components/settings/HomePersonalSettings.tsx b/apps/roam/src/components/settings/HomePersonalSettings.tsx index 46dd79c52..c153842c9 100644 --- a/apps/roam/src/components/settings/HomePersonalSettings.tsx +++ b/apps/roam/src/components/settings/HomePersonalSettings.tsx @@ -1,6 +1,6 @@ import React from "react"; import { OnloadArgs } from "roamjs-components/types"; -import { Label, Switch } from "@blueprintjs/core"; +import { Checkbox, Label, Switch } from "@blueprintjs/core"; import Description from "roamjs-components/components/Description"; import { NodeMenuTriggerComponent } from "../DiscourseNodeMenu"; import { @@ -24,7 +24,7 @@ const HomePersonalSettings = ({ onloadArgs }: { onloadArgs: OnloadArgs }) => { /> - { } /> - { } /> - { const target = e.target as HTMLInputElement; diff --git a/apps/roam/src/components/settings/QuerySettings.tsx b/apps/roam/src/components/settings/QuerySettings.tsx index 4a0305ba8..b82665933 100644 --- a/apps/roam/src/components/settings/QuerySettings.tsx +++ b/apps/roam/src/components/settings/QuerySettings.tsx @@ -1,6 +1,6 @@ import React from "react"; import { OnloadArgs } from "roamjs-components/types"; -import { Label, NumericInput, Switch } from "@blueprintjs/core"; +import { Checkbox, Label, NumericInput } from "@blueprintjs/core"; import Description from "roamjs-components/components/Description"; import { getSettings } from "~/utils/parseResultSettings"; import { DEFAULT_PAGE_SIZE_KEY, HIDE_METADATA_KEY } from "~/data/userSettings"; @@ -15,7 +15,7 @@ const QuerySettings = ({ const { globalPageSize } = getSettings(extensionAPI); return (
- { const target = e.target as HTMLInputElement; From 58c6dcfd79e55d4d31b6d2e1bb3e4e76edb5eb25 Mon Sep 17 00:00:00 2001 From: sid597 Date: Thu, 27 Mar 2025 17:47:10 +0530 Subject: [PATCH 6/9] unused imports --- apps/roam/src/components/settings/HomePersonalSettings.tsx | 2 +- apps/roam/src/components/settings/QuerySettings.tsx | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/apps/roam/src/components/settings/HomePersonalSettings.tsx b/apps/roam/src/components/settings/HomePersonalSettings.tsx index c153842c9..4e01697d5 100644 --- a/apps/roam/src/components/settings/HomePersonalSettings.tsx +++ b/apps/roam/src/components/settings/HomePersonalSettings.tsx @@ -1,6 +1,6 @@ import React from "react"; import { OnloadArgs } from "roamjs-components/types"; -import { Checkbox, Label, Switch } from "@blueprintjs/core"; +import { Checkbox, Label } from "@blueprintjs/core"; import Description from "roamjs-components/components/Description"; import { NodeMenuTriggerComponent } from "../DiscourseNodeMenu"; import { diff --git a/apps/roam/src/components/settings/QuerySettings.tsx b/apps/roam/src/components/settings/QuerySettings.tsx index b82665933..988680dc2 100644 --- a/apps/roam/src/components/settings/QuerySettings.tsx +++ b/apps/roam/src/components/settings/QuerySettings.tsx @@ -1,6 +1,6 @@ import React from "react"; import { OnloadArgs } from "roamjs-components/types"; -import { Checkbox, Label, NumericInput } from "@blueprintjs/core"; +import { Label, NumericInput, Checkbox } from "@blueprintjs/core"; import Description from "roamjs-components/components/Description"; import { getSettings } from "~/utils/parseResultSettings"; import { DEFAULT_PAGE_SIZE_KEY, HIDE_METADATA_KEY } from "~/data/userSettings"; From 140bff8a036ec107233b6db794c54c1897829289 Mon Sep 17 00:00:00 2001 From: sid597 Date: Thu, 27 Mar 2025 17:48:17 +0530 Subject: [PATCH 7/9] . --- apps/roam/src/components/settings/HomePersonalSettings.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/apps/roam/src/components/settings/HomePersonalSettings.tsx b/apps/roam/src/components/settings/HomePersonalSettings.tsx index 4e01697d5..9251b7bc6 100644 --- a/apps/roam/src/components/settings/HomePersonalSettings.tsx +++ b/apps/roam/src/components/settings/HomePersonalSettings.tsx @@ -1,6 +1,6 @@ import React from "react"; import { OnloadArgs } from "roamjs-components/types"; -import { Checkbox, Label } from "@blueprintjs/core"; +import { Label, Checkbox } from "@blueprintjs/core"; import Description from "roamjs-components/components/Description"; import { NodeMenuTriggerComponent } from "../DiscourseNodeMenu"; import { From d239e4ebb6d58cd941876506091eab33e7546358 Mon Sep 17 00:00:00 2001 From: sid597 Date: Sat, 29 Mar 2025 10:00:54 +0530 Subject: [PATCH 8/9] switch from switches to checkboxes --- .../src/components/settings/DiscourseNodeCanvasSettings.tsx | 6 +++--- .../src/components/settings/DiscourseNodeSpecification.tsx | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/apps/roam/src/components/settings/DiscourseNodeCanvasSettings.tsx b/apps/roam/src/components/settings/DiscourseNodeCanvasSettings.tsx index 4638fa7bf..4dd928491 100644 --- a/apps/roam/src/components/settings/DiscourseNodeCanvasSettings.tsx +++ b/apps/roam/src/components/settings/DiscourseNodeCanvasSettings.tsx @@ -3,10 +3,10 @@ import { Label, Radio, RadioGroup, - Switch, Tooltip, Icon, ControlGroup, + Checkbox, } from "@blueprintjs/core"; import React, { useState, useMemo } from "react"; import getBasicTreeByParentUid from "roamjs-components/queries/getBasicTreeByParentUid"; @@ -91,7 +91,7 @@ const DiscourseNodeCanvasSettings = ({ uid }: { uid: string }) => { }} /> - { className={"ml-2 align-middle opacity-80"} /> - + {/* */}

- { From 4a444f0edb745b0be454785f3c49b082fe97e4cb Mon Sep 17 00:00:00 2001 From: Michael Gartner Date: Sun, 30 Mar 2025 16:27:37 -0600 Subject: [PATCH 9/9] remove right align to match other settings --- .../roam/src/components/settings/DiscourseNodeCanvasSettings.tsx | 1 - 1 file changed, 1 deletion(-) diff --git a/apps/roam/src/components/settings/DiscourseNodeCanvasSettings.tsx b/apps/roam/src/components/settings/DiscourseNodeCanvasSettings.tsx index 4dd928491..ac26daf7f 100644 --- a/apps/roam/src/components/settings/DiscourseNodeCanvasSettings.tsx +++ b/apps/roam/src/components/settings/DiscourseNodeCanvasSettings.tsx @@ -93,7 +93,6 @@ const DiscourseNodeCanvasSettings = ({ uid }: { uid: string }) => { { const target = e.target as HTMLInputElement;