From d092bceb2847bc7a842fa59aa41ff16fab7ebb65 Mon Sep 17 00:00:00 2001 From: Michael Gartner Date: Fri, 9 May 2025 17:50:51 -0600 Subject: [PATCH 1/2] remove focus after menu select to allow updateBlock to work --- apps/roam/src/components/DiscourseNodeMenu.tsx | 2 ++ 1 file changed, 2 insertions(+) diff --git a/apps/roam/src/components/DiscourseNodeMenu.tsx b/apps/roam/src/components/DiscourseNodeMenu.tsx index 53375fee3..65d6e8523 100644 --- a/apps/roam/src/components/DiscourseNodeMenu.tsx +++ b/apps/roam/src/components/DiscourseNodeMenu.tsx @@ -111,8 +111,10 @@ const NodeMenu = ({ menuRef.current?.getAttribute("data-active-index"), ); onSelect(index); + document.body.click(); } else if (shortcuts.has(e.key.toUpperCase())) { onSelect(indexBySC[e.key.toUpperCase()]); + document.body.click(); } else { return; } From f713349b3c7132e87d2bc6688821799abdd3c916 Mon Sep 17 00:00:00 2001 From: Michael Gartner Date: Fri, 9 May 2025 18:20:19 -0600 Subject: [PATCH 2/2] add clarifying comment --- apps/roam/src/components/DiscourseNodeMenu.tsx | 2 ++ 1 file changed, 2 insertions(+) diff --git a/apps/roam/src/components/DiscourseNodeMenu.tsx b/apps/roam/src/components/DiscourseNodeMenu.tsx index 65d6e8523..d8140cc9f 100644 --- a/apps/roam/src/components/DiscourseNodeMenu.tsx +++ b/apps/roam/src/components/DiscourseNodeMenu.tsx @@ -111,9 +111,11 @@ const NodeMenu = ({ menuRef.current?.getAttribute("data-active-index"), ); onSelect(index); + // Remove focus from the block to ensure updateBlock works properly document.body.click(); } else if (shortcuts.has(e.key.toUpperCase())) { onSelect(indexBySC[e.key.toUpperCase()]); + // Remove focus from the block to ensure updateBlock works properly document.body.click(); } else { return;