[ENG-363] Node search menu UI bug

[trangdoan982]

https://www.loom.com/share/c8e96010a98b43da83376cfa999ca9d5

Summary by CodeRabbit

• Style
  • Improved the vertical positioning of popover menus, ensuring they display with better alignment above target elements.

[linear]

ENG-363 Filter Bug

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment

Name	Status	Preview	Comments	Updated (UTC)
discourse-graph	⬜️ Skipped (Inspect)			Jun 23, 2025 8:56pm

[supabase]

This pull request has been ignored for the connected project plzkmulvmuhdpcmnyrhm because there are no changes detected in projects/database/supabase/supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.

---

Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

📝 Walkthrough

Walkthrough

A custom Popper.js modifier named offset was added to the Popover component in NodeSearchMenu. This modifier adjusts the popover's vertical position by subtracting 30 pixels from the top offset when the popper is placed above the target element.

Changes

File(s)	Change Summary
apps/roam/src/components/DiscourseNodeSearchMenu.tsx	Added a Popper.js offset modifier to adjust vertical position when placement is "top".

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant NodeSearchMenu
    participant Popover
    participant Popper.js

    User->>NodeSearchMenu: Triggers popover display
    NodeSearchMenu->>Popover: Render with modifiers
    Popover->>Popper.js: Apply modifiers (including custom offset)
    Popper.js-->>Popover: Calculates position (subtracts 30px from top if needed)
    Popover-->>NodeSearchMenu: Displays adjusted popover

Loading

Possibly related PRs

• [ENG-235] Create DG summoning menu #169: Modifies Popper.js positioning logic in the same NodeSearchMenu component.
• [ENG-259] Create Observer and UI pattern #138: Enhances Popper.js positioning logic within the NodeSearchMenu component.

Suggested reviewers

• mdroidian

Poem

A popper floats, but now it knows
To lift itself where cool wind blows.
Thirty pixels higher, see?
Above the node, it’s meant to be.
With every hop, the menu’s right—
A rabbit’s tweak for perfect height! 🐇✨

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[trangdoan982]

@coderabbitai review

[coderabbitai]

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

apps/roam/src/components/DiscourseNodeSearchMenu.tsx (1)

407-415: The positioning fix looks correct but consider addressing potential edge cases.

The custom offset modifier properly adjusts the popover position when placed above the target element. However, there are a few considerations:

1. Magic number: The 30px offset is hardcoded - consider extracting it as a named constant for maintainability
2. Defensive programming: Add safety checks for the data structure
3. API compatibility: Ensure this syntax remains compatible with the Popper.js version used by Blueprint.js

Consider this defensive approach:

-        offset: {
-          enabled: true,
-          fn: (data) => {
-            if (data.placement.startsWith("top")) {
-              data.offsets.popper.top -= 30;
-            }
-            return data;
-          },
-        },
+        offset: {
+          enabled: true,
+          fn: (data) => {
+            if (data.placement?.startsWith("top") && data.offsets?.popper) {
+              data.offsets.popper.top -= POPOVER_TOP_OFFSET;
+            }
+            return data;
+          },
+        },

And add at the top of the file:

+const POPOVER_TOP_OFFSET = 30; // Adjustment for top-positioned popover to prevent overlap

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 13c7ac3 and 5d54b6f.

📒 Files selected for processing (1)

• apps/roam/src/components/DiscourseNodeSearchMenu.tsx (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: deploy

[mdroidian]

🔥