From 62b1d3482632273f1c6bae58477d393fd363e9a4 Mon Sep 17 00:00:00 2001 From: Michael Gartner Date: Wed, 27 Aug 2025 01:06:09 -0600 Subject: [PATCH 1/2] Enhance Tldraw canvas rendering by setting TLDRAW_DATA_ATTRIBUTE on root element and updating CSS selectors for block visibility. Removed commented-out code for cleaner implementation. --- apps/roam/src/components/canvas/Tldraw.tsx | 10 +--------- apps/roam/src/components/canvas/tldrawStyles.ts | 4 ++-- 2 files changed, 3 insertions(+), 11 deletions(-) diff --git a/apps/roam/src/components/canvas/Tldraw.tsx b/apps/roam/src/components/canvas/Tldraw.tsx index 5413fb186..f84751bf6 100644 --- a/apps/roam/src/components/canvas/Tldraw.tsx +++ b/apps/roam/src/components/canvas/Tldraw.tsx @@ -936,6 +936,7 @@ const renderTldrawCanvasHelper = ({ childFromRoot.parentElement && !childFromRoot.hasAttribute(TLDRAW_DATA_ATTRIBUTE) ) { + rootElement.setAttribute(TLDRAW_DATA_ATTRIBUTE, "true"); childFromRoot.setAttribute(TLDRAW_DATA_ATTRIBUTE, "true"); const parentEl = childFromRoot.parentElement; parentEl.appendChild(canvasWrapperEl); @@ -943,15 +944,6 @@ const renderTldrawCanvasHelper = ({ canvasWrapperEl.style.height = height; } - // console.log( - // "blockChildrenContainer.parentElement", - // articleChildren.parentElement, - // ); - // articleChildren.parentElement?.insertBefore( - // canvasWrapperEl, - // articleChildren.nextSibling, - // ); - const unmount = renderWithUnmount( diff --git a/apps/roam/src/components/canvas/tldrawStyles.ts b/apps/roam/src/components/canvas/tldrawStyles.ts index 14f004e5a..46acf3621 100644 --- a/apps/roam/src/components/canvas/tldrawStyles.ts +++ b/apps/roam/src/components/canvas/tldrawStyles.ts @@ -2,12 +2,12 @@ export const TLDRAW_DATA_ATTRIBUTE = "dg-tldraw-canvas-wrapper"; export default ` /* Hide Roam Blocks only when canvas is present */ - .roam-article .rm-block-children[${TLDRAW_DATA_ATTRIBUTE}="true"] { + .roam-article[${TLDRAW_DATA_ATTRIBUTE}="true"] .rm-block-children { display: none; } /* Hide Roam Blocks in sidebar when canvas is present */ - .rm-sidebar-outline .rm-block-children[${TLDRAW_DATA_ATTRIBUTE}="true"] { + .rm-sidebar-outline[${TLDRAW_DATA_ATTRIBUTE}="true"] .rm-block-children { display: none; } From 9b6974fe6fcbba0922824923a13185cf0b2503a6 Mon Sep 17 00:00:00 2001 From: Michael Gartner Date: Wed, 27 Aug 2025 01:16:06 -0600 Subject: [PATCH 2/2] rm on unmount --- apps/roam/src/components/canvas/Tldraw.tsx | 1 + 1 file changed, 1 insertion(+) diff --git a/apps/roam/src/components/canvas/Tldraw.tsx b/apps/roam/src/components/canvas/Tldraw.tsx index f84751bf6..4ac11d5a4 100644 --- a/apps/roam/src/components/canvas/Tldraw.tsx +++ b/apps/roam/src/components/canvas/Tldraw.tsx @@ -955,6 +955,7 @@ const renderTldrawCanvasHelper = ({ return () => { originalUnmount(); childFromRoot.removeAttribute(TLDRAW_DATA_ATTRIBUTE); + rootElement.removeAttribute(TLDRAW_DATA_ATTRIBUTE); canvasWrapperEl.remove(); }; };