ENG-790 - Referencing an EVD or RES node on canvas is creating a duplicate node with additional tag #390
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replaced promise chaining with async/await and try/catch for improved error handling. - Simplified the fetching logic for main and referenced node options. - Updated useEffect dependencies for better clarity and performance. - Changed referencedNode retrieval to use useMemo for optimization.
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
Contributor
Author
|
@CodeRabbit full review |
Contributor
✅ Actions performedFull review triggered. |
Contributor
📝 WalkthroughWalkthroughRefactors LabelDialogAutocomplete to use an async fetchOptions with async/await and proper loading/error handling, replacing timer- and promise-chained logic. Adds memoized referencedNode computation in LabelDialog. Updates effects and props wiring. Introduces separate queries for main nodeType and optional referenced node type. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor U as User
participant LD as LabelDialog
participant LDA as LabelDialogAutocomplete
participant Q as fireQuery
U->>LD: Open Label Dialog
LD->>LD: useMemo compute referencedNode
LD->>LDA: Render with nodeType, isAddReferencedNode, referencedNode
rect rgba(200,230,255,0.3)
note right of LDA: Fetch main options
LDA->>LDA: setLoading(true)
LDA->>Q: fireQuery(nodeType, uid₁)
Q-->>LDA: options
LDA->>LDA: setOptions(...)
LDA->>LDA: setLoading(false)
end
alt isAddReferencedNode && referencedNode
rect rgba(220,255,220,0.3)
note right of LDA: Fetch referenced node options
LDA->>LDA: setLoading(true)
LDA->>Q: fireQuery(referencedNode.nodeType, uid₂)
Q-->>LDA: referenced options
LDA->>LDA: setReferencedNodeOptions(...)
LDA->>LDA: setLoading(false)
end
else No referenced fetch
note right of LDA: Skip referenced fetch
end
opt Error case
LDA->>LDA: catch -> console.error(...)
LDA->>LDA: setLoading(false)
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
apps/roam/src/components/canvas/LabelDialog.tsx (1)
328-347: Avoid dynamic RegExp usage and variable shadowing in LabelDialog.tsx
- In the
useMemoblock (around lines 335–343), rename the innerreferencedNodetorefNodeand replace the unsafe regex test with a case-insensitive string comparison:- const referencedNode = Object.values(discourseContext.nodes).find( - ({ text }) => new RegExp(text, "i").test(val), - ); - if (referencedNode) { - return { name: referencedNode.text, nodeType: referencedNode.type }; + const refNode = Object.values(discourseContext.nodes).find( + ({ text }) => text.toLowerCase() === val.toLowerCase(), + ); + if (refNode) { + return { name: refNode.text, nodeType: refNode.type };
- In the
setValuecallback (around line 133), replace the dynamic regex with a direct comparison:- if ( - referencedNode && - new RegExp(referencedNode.name, "i").test(val) && - isAddReferencedNode - ) + if ( + referencedNode && + referencedNode.name.toLowerCase() === val.toLowerCase() && + isAddReferencedNode + )
🧹 Nitpick comments (1)
apps/roam/src/components/canvas/LabelDialog.tsx (1)
221-224: Prefer e.currentTarget over e.target in Checkbox onChangeUsing
e.targetcan be wrong when events bubble from nested elements.currentTargetis the checkbox.- onChange={(e) => { - const checked = e.target as HTMLInputElement; - setIsEditExistingLabel(checked.checked); - }} + onChange={(e) => setIsEditExistingLabel(e.currentTarget.checked)}- onChange={(e) => { - const checked = e.target as HTMLInputElement; - setAddReferencedNode(checked.checked); - }} + onChange={(e) => setAddReferencedNode(e.currentTarget.checked)}Also applies to: 238-241
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
apps/roam/src/components/canvas/LabelDialog.tsx(3 hunks)
- Introduced request ID tracking to prevent stale state updates during asynchronous fetching. - Added cleanup logic in useEffect to manage component lifecycle and avoid memory leaks. - Improved error handling to ensure console errors are logged only for the latest request. - Maintained existing async/await structure for fetching options, enhancing clarity and performance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
Bug Fixes
Performance & UX
Refactor