ENG-808 Repair turbo dev #392
Conversation
because `turbo dev -F @repo/database` expects `@repo/utils` to be built. Adding the turbo dependencies to that effect. Also making the database a non-dev dependency of website.
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
turbo.json
Outdated
| "dependsOn": [ | ||
| "@repo/database#build", | ||
| "@repo/ui#build", | ||
| "@repo/database#build" |
There was a problem hiding this comment.
Does "@repo/database#build" need to be in here twice?
There was a problem hiding this comment.
Good catch. The first one was meant to be utils.
mdroidian
left a comment
mdroidian
left a comment
There was a problem hiding this comment.
Actually we should probably try to find a different way to do this.
Looks like this makes turbo dev -F roam build ui which should not be required. The @repo/packages build should be dependent on if they are used, and they need to be watched and rebuilt.
|
Actually, good point about recursive dependencies. I set it up so dev depends on recursive build, which is more targeted. |
|
@maparent package.lock needs to be updated from this PR. |
https://linear.app/discourse-graphs/issue/ENG-808/repair-turbo-dev
On an empty repo,
turbo devfails becauseturbo dev -F @repo/databaseexpects@repo/utilsto be built.Adding the turbo dependencies to that effect.
Also making the database a non-dev dependency of website.