From 3439b0c299d6a77a034d4cd9f5bd8c8690a73cff Mon Sep 17 00:00:00 2001 From: sid597 Date: Wed, 8 Oct 2025 15:39:01 +0530 Subject: [PATCH 1/3] remove open target call for personal section header --- apps/roam/src/components/LeftSidebarView.tsx | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/apps/roam/src/components/LeftSidebarView.tsx b/apps/roam/src/components/LeftSidebarView.tsx index 57cc0747d..81bc63401 100644 --- a/apps/roam/src/components/LeftSidebarView.tsx +++ b/apps/roam/src/components/LeftSidebarView.tsx @@ -218,11 +218,9 @@ const PersonalSectionItem = ({
{ + onClick={() => { if ((section.children?.length || 0) > 0) { handleChevronClick(); - } else { - void openTarget(e, section.text); } }} > @@ -574,6 +572,11 @@ const FavouritesPopover = ({ onloadArgs }: { onloadArgs: OnloadArgs }) => { const LeftSidebarView = ({ onloadArgs }: { onloadArgs: OnloadArgs }) => { const initialConfig = useConfig(); const [config, setConfig] = useState(initialConfig); + + useEffect(() => { + setConfig(initialConfig); + }, [initialConfig]); + return ( <> From ee3703b45047cf840b9771b45a684b90de376f77 Mon Sep 17 00:00:00 2001 From: sid597 Date: Sun, 19 Oct 2025 23:30:40 +0530 Subject: [PATCH 2/3] fix useconfig hook, fix overflow-scroll bug in left sidebar view --- apps/roam/src/components/LeftSidebarView.tsx | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/apps/roam/src/components/LeftSidebarView.tsx b/apps/roam/src/components/LeftSidebarView.tsx index 81bc63401..4d23310ef 100644 --- a/apps/roam/src/components/LeftSidebarView.tsx +++ b/apps/roam/src/components/LeftSidebarView.tsx @@ -450,7 +450,7 @@ export const useConfig = () => { unsubscribe(); }; }, []); - return config; + return { config, setConfig }; }; export const refreshAndNotify = () => { @@ -570,12 +570,7 @@ const FavouritesPopover = ({ onloadArgs }: { onloadArgs: OnloadArgs }) => { }; const LeftSidebarView = ({ onloadArgs }: { onloadArgs: OnloadArgs }) => { - const initialConfig = useConfig(); - const [config, setConfig] = useState(initialConfig); - - useEffect(() => { - setConfig(initialConfig); - }, [initialConfig]); + const { config, setConfig } = useConfig(); return ( <> @@ -602,7 +597,7 @@ export const mountLeftSidebar = ( } root = document.createElement("div"); root.id = id; - root.className = "starred-pages overflow-scroll"; + root.className = "starred-pages"; root.onmousedown = (e) => e.stopPropagation(); wrapper.appendChild(root); } else { From 54d3e6edf8f368377a2f34f34996a2d834b3f584 Mon Sep 17 00:00:00 2001 From: sid597 Date: Sun, 19 Oct 2025 23:43:27 +0530 Subject: [PATCH 3/3] fix overflow-scroll bug in left sidebar view --- apps/roam/src/components/LeftSidebarView.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/apps/roam/src/components/LeftSidebarView.tsx b/apps/roam/src/components/LeftSidebarView.tsx index 4d23310ef..009a75cdc 100644 --- a/apps/roam/src/components/LeftSidebarView.tsx +++ b/apps/roam/src/components/LeftSidebarView.tsx @@ -601,7 +601,7 @@ export const mountLeftSidebar = ( root.onmousedown = (e) => e.stopPropagation(); wrapper.appendChild(root); } else { - root.className = "starred-pages overflow-scroll"; + root.className = "starred-pages"; } ReactDOM.render(, root); };