-
Notifications
You must be signed in to change notification settings - Fork 3
ENG-958 - Obsidian documentation for Canvas feature #484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
|
@coderabbitai full review |
✅ Actions performedFull review triggered. |
📝 WalkthroughWalkthroughAdds a new "Canvas" entry to the Obsidian docs navigation and introduces a new Canvas documentation page describing features, workflows, and troubleshooting. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Pre-merge checks✅ Passed checks (3 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
🧹 Nitpick comments (1)
apps/website/app/(docs)/docs/obsidian/pages/canvas.md (1)
4-4: Consider adding an author name.The
authorfield is empty. If attribution is desired, consider adding the author's name.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (12)
apps/website/public/apps/assets/node-color-icon.svgis excluded by!**/*.svgapps/website/public/apps/assets/tool-arrow-icon.svgis excluded by!**/*.svgapps/website/public/docs/obsidian/adding-existing-relations.gifis excluded by!**/*.gifapps/website/public/docs/obsidian/canvas-icon-button.pngis excluded by!**/*.pngapps/website/public/docs/obsidian/create-canvas-command.pngis excluded by!**/*.pngapps/website/public/docs/obsidian/create-discourse-node.gifis excluded by!**/*.gifapps/website/public/docs/obsidian/create-relations.gifis excluded by!**/*.gifapps/website/public/docs/obsidian/export-options.pngis excluded by!**/*.pngapps/website/public/docs/obsidian/node-search.gifis excluded by!**/*.gifapps/website/public/docs/obsidian/open-canvas-command.pngis excluded by!**/*.pngapps/website/public/docs/obsidian/relation-error.pngis excluded by!**/*.pngapps/website/public/docs/obsidian/search-filtering.gifis excluded by!**/*.gif
📒 Files selected for processing (2)
apps/website/app/(docs)/docs/obsidian/navigation.ts(1 hunks)apps/website/app/(docs)/docs/obsidian/pages/canvas.md(1 hunks)
🔇 Additional comments (3)
apps/website/app/(docs)/docs/obsidian/pages/canvas.md (2)
66-66: Verify the correct icon reference.The instruction says "Click the Discourse Node icon" in the Relations section. Should this be "Discourse Relation icon" instead? Please verify that the correct icon is referenced.
7-125: Documentation is comprehensive and well-structured.The Canvas documentation provides clear instructions, helpful visuals, and thorough troubleshooting guidance. The content effectively covers creation, editing, nodes, relations, features, and common issues.
apps/website/app/(docs)/docs/obsidian/navigation.ts (1)
58-61: Navigation entry properly integrated.The Canvas navigation entry is correctly placed in the Core Features section and properly references the new documentation page at
/docs/obsidian/canvas.
|
@trangdoan982 let's make sure to include linear tickets and call coderabbit, even for documentation. |
mdroidian
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just noting: make sure to run this through coderabbit, even on docs
Also make sure to tie to a linear ticket.
Lastly, I made some comments on lowercase, as per our recent capitalization convention conversation. But feel free to leave them as is so that it is uniform with the rest, until ENG-892: go through and revert capitalization of branded components in the repo
Worth noting for the future: based on that conversation, we'll also be going sentence case for headlines too (h1,h2,h3, **Bolded headlines**, etc), eg ### Create New Relations Between Nodes
Early merge so that Sean can test out and use the pre-release for tldraw
Summary by CodeRabbit